8000 Adding resize observer to support viewport change by bandana147 · Pull Request #4418 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding resize observer to support viewport change #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

Adding resize observer to support viewport change #4418

merged 1 commit into from
Jul 5, 2025

Conversation

bandana147
Copy link
Contributor
@bandana147 bandana147 commented Jun 17, 2025 •
edited by github-actions bot
Loading
  • Adding the resize observer of promo height change to support responsive view port changes.
  • Note: This was reverted as it was failing when the promopath is present but is not a valid promo url. To handle this we are adding a check if the promo element is instance of HTMLElement and then only we will be adding the resize observer.
    Reverted PR - Adding mutation observer to support viewport change #4388

Resolves: MWPW-174961

Test URLs:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 17, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 17, 2025
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 17, 2025
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@spadmasa spadmasa added the needs-verification PR requires E2E testing by a reviewer label Jun 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@prativas22
Copy link

The resize promo height was verified to support responsive viewport mode using below URLs.
https://main--cc--adobecom.aem.live/mx/creativecloud?milolibs=gnav-promo-height
image
https://main--cc--adobecom.aem.live/ae_ar/creativecloud?milolibs=gnav-promo-height
image
image
https://main--homepage--adobecom.aem.live/in/homepage/index-loggedout?milolibs=gnav-promo-height
image
image

The results of the QA test are included in the ticket for reference https://jira.corp.adobe.com/browse/MWPW-174961

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jun 30, 2025
@milo-pr-merge milo-pr-merge bot merged commit 1ff0751 into stage Jul 5, 2025
26 of 27 checks passed
@milo-pr-merge milo-pr-merge bot deleted the gnav-promo-height branch July 5, 2025 08:21
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 5, 2025
Merged
bandana147 added a commit that referenced this pull request Jul 8, 2025
@bandana147
Revert "Adding resize observer to support viewport change (#4418)"
3a3f5b4 
This reverts commit 1ff0751.
@bandana147 bandana147 mentioned this pull request Jul 8, 2025
Merged
mokimo pushed a commit that referenced this pull request Jul 8, 2025
@bandana147
Revert "Adding resize observer to support viewport change" (#4513)
1b625cf 
Revert "Adding resize observer to support viewport change (#4418)"

This reverts commit 1ff0751.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonHowellSlavin JasonHowellSlavin JasonHowellSlavin approved these changes

@sharmrj sharmrj sharmrj approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@nishantka nishantka Awaiting requested review from nishantka

@Deva309 Deva309 Awaiting requested review from Deva309

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bandana147 @prativas22 @JasonHowellSlavin @sharmrj @spadmasa
0