8000 MWPW-174488 [Gnav Performance] Dark Theme for Ghost state by sharmrj · Pull Request #4404 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-174488 [Gnav Performance] Dark Theme for Ghost state #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 5, 2025
Merged

MWPW-174488 [Gnav Performance] Dark Theme for Ghost state #4404

merged 7 commits into from
Jul 5, 2025

Conversation

sharmrj
Copy link
Contributor
@sharmrj sharmrj commented Jun 16, 2025 •
edited by github-actions bot
Loading

This adds two more fixes in addition to the more button skeleton.

  • More Button no longer shows up in the skeleton
    • This was done in transformTemplateToMobile. We call await promoCrossCloudTab() only if we are not in the loading state; we determine if we are in the loading state by doing popup.classList.contains('loading').
    • As a side effect, this mitigates a delay in the menu showing up as we have to wait on a placeholders file to be fetched for promoCrossCloudTab
  • Added Darkmode css for the loading state
    • Refactored the loading state skeleton to use css variables for its colors.
    • Added the darkmode colors to dark-nav.css
    • Moved the addition of the feds--dark class to before await gnav.init() to avoid a bug with the loading state background on mobile darkmode.
  • Fixed an issue where the desktop loading state was showing up on mobile viewports for a split second
    • this was happening because inside decorateDropdowns we await the network request for menu.js.
    • So we refactor all the decorateMenu logic into it's own non-awaited IIFE.
    • We change any .then into regular async/await and use try and finally (catch isn't required at this time)

Resolves:

Test URLs:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 16, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 16, 2025 •
edited
Loading
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to more-button-skeleton June 17, 2025 08:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to more-button-skeleton June 17, 2025 11:30 Inactive
@sharmrj sharmrj force-pushed the more-button-skeleton branch from 33ff8ac to ce14fe9 Compare June 17, 2025 11:34
@aem-code-sync aem-code-sync bot temporarily deployed to more-button-skeleton June 17, 2025 11:34 Inactive
@spadmasa spadmasa added the needs-verification PR requires E2E testing by a reviewer label Jun 24, 2025
@sharmrj sharmrj requested a review from a team as a code owner June 25, 2025 13:55
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 1, 2025

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@prativas22
Copy link

Verified the PR fix for ghost state on dark theme and More button

https://adobecom.github.io/nav-consumer/navigation.html?authoringpath=/federal/learn&navbranch=more-button-skeleton&customlinks=home,learn,apps,discover,files&theme=dark
image

image

The QA test results are included in the tickets below for reference.
https://jira.corp.adobe.com/browse/MWPW-174488
https://jira.corp.adobe.com/browse/MWPW-174174
https://jira.corp.adobe.com/browse/MWPW-174183

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Jul 1, 2025
@milo-pr-merge milo-pr-merge bot merged commit 81ac469 into stage Jul 5, 2025
22 checks passed
@milo-pr-merge milo-pr-merge bot deleted the more-button-skeleton branch July 5, 2025 08:21
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salonijain3 salonijain3 salonijain3 approved these changes

@nishantka nishantka nishantka approved these changes

@sonawanesnehal3 sonawanesnehal3 sonawanesnehal3 approved these changes

@bandana147 bandana147 Awaiting requested review from bandana147

@Deva309 Deva309 Awaiting requested review from Deva309

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sharmrj @prativas22 @salonijain3 @nishantka @sonawanesnehal3 @spadmasa
0