8000 Mweb cards carousel by suhjainadobe · Pull Request #4339 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mweb cards carousel #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

suhjainadobe
Copy link
Contributor
@suhjainadobe suhjainadobe commented Jun 9, 2025

editorial cards white text for other viewports, da-ll addition, smoothening swapping function for carousel.

  • Add your
  • Specific
  • Features or fixes

Resolves: MWPW-174696

Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://mweb-cards-carousel--milo--suhjainadobe.aem.page/drafts/suhjain/m2-folder/carousel/document1?mep=/drafts/suhjain/ace1052.json&martech=off&georouting=off

@aishwaryamathuria aishwaryamathuria self-requested a review June 9, 2025 10:12
@aishwaryamathuria aishwaryamathuria merged commit 99fe7ee into adobecom:mweb-dev Jun 9, 2025
10 of 12 checks passed
overmyheadandbody pushed a commit that referenced this pull request Jun 11, 2025
* MWPW-174696, da-ll addition, swipping function

* MWPW-174696, da-ll addition, swipping function

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
overmyheadandbody pushed a commit that referenced this pull request Jun 11, 2025
* MWPW-174696, da-ll addition, swipping function

* MWPW-174696, da-ll addition, swipping function

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
overmyheadandbody added a commit that referenced this pull request Jun 12, 2025
* carousel css changes for mweb

* adding show more cards CTA on editorial cards

* Revert "adding show more cards CTA on editorial cards"

This reverts commit 470670c.

* Revert "Revert "adding show more cards CTA on editorial cards""

This reverts commit 501f01a.

* adding show more cards CTA on editorial cards

* adding show more cards CTA on editorial cards

* [MWPW-171554][mweb-dev] mWeb Ps Journey | Notification block update - 'Sticky CTA' (#4244)

* mweb sticky notification

* MWPW-173875 (#4233)

* MWPW-173875

Leadership wants these logs out before the RCP

* mweb

---------

Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-171432 | Moving hero marquee mweb test css to bottom (#4265)

Change to move mweb css at bottom

* Mweb tabs, editorial cards, icon block (#4259)

* notification mweb css

* notification mweb css

* MWPW-171542 | Hiding the hinting cards (#4277)

* hiding the hinting cards

* Update editorial-card.js

* Update editorial-card.css

* Update editorial-card.css

* Update editorial-card.css

* Update editorial-card.js

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
Co-authored-by: Aishwarya Mathuria <mathuria@adobe.com>

* Minor tweaks for mweb blocks (#4280)

* Minor tweaks for mweb blocks

* Adapt layout for expandable editorial cards

* section metadata

* Carousel hinting card height (#4287)

* adjusting the height of the hinting card and little tweeks

* adjusting the height of the hinting card and little tweeks

* adjusting the border radius of the see more button

* adjusting the border radius of the see more button

* adjusting the border radius of the see more button

* adjusting the border radius of the see more button

* adjusting the border radius of the see more button

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>

* notification update

* Re-merge: limit tabs upates; lower aside margins (#4328)

* [MWPW-171554][mweb-dev] mWeb Ps Journey | Notification block update - 'Sticky CTA' (#4244)

* mweb sticky notification

* MWPW-173875 (#4233)

* MWPW-173875

Leadership wants these logs out before the RCP

* mweb

---------

Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* Limit tabs upates; lower aside margins

---------

Co-authored-by: Drashti Modasara <drashti1712@gmail.com>
Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* editorial css and carousel width changes (#4329)

* editorial css and carousel width changes

* editorial css and carousel width changes

* editorial css and carousel width changes

* editorial css and carousel width changes

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>

* Mweb cards carousel (#4339)

* MWPW-174696, da-ll addition, swipping function

* MWPW-174696, da-ll addition, swipping function

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>

* block size for notification

* Bring the latest block changes into the mweb feature branch (#4337)

Bring in latest block updates

* MWPW-174782 and MWPW-174694 (#4353)

* MWPW-174782 and MWPW-174694

* MWPW-174782 and MWPW-174694

* MWPW-174782 and MWPW-174694

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>

* Minor editorial card adjustment (#4354)

* MWPW-174846 adding margin bottom for editorial cards (#4362)

adding margin bottom for editorial cards

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>

* mweb-notification

* [MWPW-174800] Re-enable carousel indicator dots (#4356)

Re-enable carousel indicator dots

* mweb-notification fix

* Fix lint issues

* [MWPW-174951] Allow centered text block link for mweb (#4384)

* [MWPW-174950] Update Brick block to body-s (#4383)

* MWPW-174950 Update Brick block to body-s

* MWPW-174950 Update Brick block to body-s

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>

---------

Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
Co-authored-by: Suhani <suhjain@suhanis-mbp.corp.adobe.com>
Co-authored-by: Drashti Modasara <drashti1712@gmail.com>
Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Aishwarya Mathuria <mathuria@adobe.com>
Co-authored-by: Suhani Jain <110388864+suhjainadobe@users.noreply.github.com>
Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0