MWPW-174782 and MWPW-174694 #4353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,7 @@ | |||
| --carousel-button-border-hover-color: #cacaca; | |||
| --carousel-button-border-focus-color: #378ef0; | |||
| --carousel-indicator-background-color: var(--carousel-button-border-hover-color); | |||
| --carousel-indicator-non-active-background-color: #8F8F8F; | |||
There was a problem hiding this comment.
Hopefully this becomes the new default, right? So I'd suggest the value be updated for --carousel-indicator-background-color. Is there a reason why that wouldn't work? I'd also suggest you add an mweb comment here as well, so we know why this was updated compared to the prod code.
There was a problem hiding this comment.
A new variable was added only because i was not sure, if these changes are to done for the prod. But as it won't affect the revert, Ill make the changes to the --carousel-indicator-background-color itself.
overmyheadandbody
approved these changes
Jun 10, 2025
salonijain3
approved these changes
Jun 10, 2025
mokimo
approved these changes
Jun 10, 2025
overmyheadandbody
pushed a commit
that referenced
this pull request
Jun 11, 2025
* MWPW-174782 and MWPW-174694 * MWPW-174782 and MWPW-174694 * MWPW-174782 and MWPW-174694 --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
overmyheadandbody
pushed a commit
that referenced
this pull request
Jun 11, 2025
* MWPW-174782 and MWPW-174694 * MWPW-174782 and MWPW-174694 * MWPW-174782 and MWPW-174694 --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
overmyheadandbody
added a commit
that referenced
this pull request
Jun 12, 2025
* carousel css changes for mweb * adding show more cards CTA on editorial cards * Revert "adding show more cards CTA on editorial cards" This reverts commit 470670c. * Revert "Revert "adding show more cards CTA on editorial cards"" This reverts commit 501f01a. * adding show more cards CTA on editorial cards * adding show more cards CTA on editorial cards * [MWPW-171554][mweb-dev] mWeb Ps Journey | Notification block update - 'Sticky CTA' (#4244) * mweb sticky notification * MWPW-173875 (#4233) * MWPW-173875 Leadership wants these logs out before the RCP * mweb --------- Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-171432 | Moving hero marquee mweb test css to bottom (#4265) Change to move mweb css at bottom * Mweb tabs, editorial cards, icon block (#4259) * notification mweb css * notification mweb css * MWPW-171542 | Hiding the hinting cards (#4277) * hiding the hinting cards * Update editorial-card.js * Update editorial-card.css * Update editorial-card.css * Update editorial-card.css * Update editorial-card.js --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> Co-authored-by: Aishwarya Mathuria <mathuria@adobe.com> * Minor tweaks for mweb blocks (#4280) * Minor tweaks for mweb blocks * Adapt layout for expandable editorial cards * section metadata * Carousel hinting card height (#4287) * adjusting the height of the hinting card and little tweeks * adjusting the height of the hinting card and little tweeks * adjusting the border radius of the see more button * adjusting the border radius of the see more button * adjusting the border radius of the see more button * adjusting the border radius of the see more button * adjusting the border radius of the see more button --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> * notification update * Re-merge: limit tabs upates; lower aside margins (#4328) * [MWPW-171554][mweb-dev] mWeb Ps Journey | Notification block update - 'Sticky CTA' (#4244) * mweb sticky notification * MWPW-173875 (#4233) * MWPW-173875 Leadership wants these logs out before the RCP * mweb --------- Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Limit tabs upates; lower aside margins --------- Co-authored-by: Drashti Modasara <drashti1712@gmail.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * editorial css and carousel width changes (#4329) * editorial css and carousel width changes * editorial css and carousel width changes * editorial css and carousel width changes * editorial css and carousel width changes --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> * Mweb cards carousel (#4339) * MWPW-174696, da-ll addition, swipping function * MWPW-174696, da-ll addition, swipping function --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> * block size for notification * Bring the latest block changes into the mweb feature branch (#4337) Bring in latest block updates * MWPW-174782 and MWPW-174694 (#4353) * MWPW-174782 and MWPW-174694 * MWPW-174782 and MWPW-174694 * MWPW-174782 and MWPW-174694 --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> * Minor editorial card adjustment (#4354) * MWPW-174846 adding margin bottom for editorial cards (#4362) adding margin bottom for editorial cards Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> * mweb-notification * [MWPW-174800] Re-enable carousel indicator dots (#4356) Re-enable carousel indicator dots * mweb-notification fix * Fix lint issues * [MWPW-174951] Allow centered text block link for mweb (#4384) * [MWPW-174950] Update Brick block to body-s (#4383) * MWPW-174950 Update Brick block to body-s * MWPW-174950 Update Brick block to body-s --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> Co-authored-by: Suhani <suhjain@suhanis-mbp.corp.adobe.com> Co-authored-by: Drashti Modasara <drashti1712@gmail.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Aishwarya Mathuria <mathuria@adobe.com> Co-authored-by: Suhani Jain <110388864+suhjainadobe@users.noreply.github.com> Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-174782
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://mweb-errors--milo--suhjainadobe.aem.page/drafts/suhjain/m2-folder/carousel/photoshop-page?mep=/drafts/suhjain/ace1052.json&martech=off&georouting=off