8000 MWPW-167847 Support .ing domains for LANA by TsayAdobe · Pull Request #4435 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-167847 Support .ing domains for LANA #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

MWPW-167847 Support .ing domains for LANA #4435

merged 1 commit into from
Jul 8, 2025

Conversation

TsayAdobe
Copy link
Contributor
@TsayAdobe TsayAdobe commented Jun 18, 2025 •
edited by github-actions bot
Loading
  • Support the DC's vanity domains: sign.ing and edit.ing.
  • Refactor the conditions with endsWith(). It's short and clear.
  • Web Test Runner can't mock window.location. No unit test coverage for the change.

Resolves: MWPW-167847

Test URLs:

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 18, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jun 18, 2025
Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
8000

@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

mokimo
mokimo approved these changes Jun 19, 2025
View reviewed changes
libs/utils/lana.js

if (host.endsWith('.adobe.com')
&& !host.endsWith('.corp.adobe.com')
&& !host.endsWith('.stage.adobe.com')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should go here host.endsWith('sign.ing') to keep this consistent 🤔

@joaquinrivero joaquinrivero added the verified PR has been E2E tested by a reviewer label Jun 23, 2025 8000
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jun 25, 2025

Skipped merging 4435: MWPW-167847 Support .ing domains for LANA due to failing or running checks

4 similar comments
@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jun 27, 2025

Skipped merging 4435: MWPW-167847 Support .ing domains for LANA due to failing or running checks

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jul 5, 2025

Skipped merging 4435: MWPW-167847 Support .ing domains for LANA due to failing or running checks

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jul 6, 2025

Skipped merging 4435: MWPW-167847 Support .ing domains for LANA due to failing or running checks

@milo-pr-merge
Copy link
Contributor
milo-pr-merge bot commented Jul 7, 2025

Skipped merging 4435: MWPW-167847 Support .ing domains for LANA due to failing or running checks

@milo-pr-merge milo-pr-merge bot merged commit 46877b4 into stage Jul 8, 2025
21 of 23 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-167847 branch July 8, 2025 08:58
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blainegunn Blainegunn Blainegunn approved these changes

@mokimo mokimo mokimo approved these changes

@joaquinrivero joaquinrivero Awaiting requested review from joaquinrivero

@Ruchika4 Ruchika4 Awaiting requested review from Ruchika4

@sanjayms01 sanjayms01 Awaiting requested review from sanjayms01

Assignees
No one assigned
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TsayAdobe @Blainegunn @mokimo @joaquinrivero
0