8000 [Release] Stage to Main by milo-pr-merge[bot] · Pull Request #4515 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Release] Stage to Main #4515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[Release] Stage to Main #4515

wants to merge 11 commits into from

Conversation

milo-pr-merge[bot]
Copy link
Contributor
@milo-pr-merge milo-pr-merge bot commented Jul 8, 2025

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

bandana147 and others added 8 commits July 8, 2025 08:58
* Fix sticky CTA block functionality issue

* adressed comments

* Add spectrum-web-components scripts to commerce documentation

* missing swc deps

* prettier fix
* support for legacy browsers that do not support url.canParse

* added additional check to validate url protocol

* validated url

* reverted formatting changes

* code enhancement

* mock for unit tests
* MWPW-167744 [Plans] Analytics

* Trigger Build

* MWPW-167744 [Plans] Analytics - unit tests

* MWPW-167744 [Plans] Analytics - lint

* MWPW-167744 [Plans] Analytics - unit tests

* MWPW-173845: Fix collection header margin for edu plans cards (#4467)

* Plans : MWPW-175390 MWPW-175488 (#4489)

* MWPW-175390 [Plans] Secure Transaction Label Alignment Issue

* MWPW-175390 [Plans] Secure Transaction Label Alignment Issue

* MWPW-175390 [Plans] Secure Transaction Label Alignment Issue

* Trigger Build

* MWPW-175488 [Plans] Schools & Universities Tab Three Card Layout Needs Centering

* build mas

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>

* MWPW-167744 [Plans] Analytics

* MWPW-167744 [Plans] Analytics - test

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
@milo-pr-merge
Copy link
Contributor Author
milo-pr-merge bot commented Jul 8, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot

@milo-pr-merge milo-pr-merge bot requested review from a team, chrischrischris and sanrai as code owners July 8, 2025 08:59
Copy link
Contributor
aem-code-sync bot commented Jul 8, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor
github-actions bot commented Jul 8, 2025

SNOW Change Request Transaction ID: 0000019746cb97b2-4488919

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

ED48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

document.querySelectorAll('code.demo').forEach(el => {
const targetContainer = document.createElement('div');
targetContainer.classList.toggle('light', el.classList.contains('light'));
targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium documentation

DOM text
is reinterpreted as HTML without escaping meta-characters.

Copilot Autofix

AI about 7 hours ago

To address the issue, the text retrieved via el.textContent should be properly escaped before being injected into the DOM. Escaping ensures that special HTML characters such as <, >, &, etc., are converted into their encoded representations (e.g., &lt;, &gt;, &amp;). This prevents any unintended interpretation as HTML or JavaScript code.

The most reliable fix involves using a library like lodash (e.g., _.escape) or a custom utility function to sanitize the text. The fix should ensure that el.textContent is sanitized before being incorporated into the innerHTML. This will require modifying the vulnerable line 62 and potentially importing a library or defining a helper function.

Suggested changeset 1
libs/features/mas/docs/commerce.html

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/features/mas/docs/commerce.html b/libs/features/mas/docs/commerce.html
--- a/libs/features/mas/docs/commerce.html
+++ b/libs/features/mas/docs/commerce.html
@@ -59,7 +59,8 @@
   document.querySelectorAll('code.demo').forEach(el => {
       const targetContainer = document.createElement('div');
       targetContainer.classList.toggle('light', el.classList.contains('light'));
-      targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;
+      const escapedText = el.textContent.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;').replace(/'/g, '&#039;');
+      targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${escapedText}</div>`;
       el.parentElement.after(targetContainer);
       // Extract and evaluate <script> tags
       const scriptTags = targetContainer.getElementsByTagName('script');
EOF
@@ -59,7 +59,8 @@
document.querySelectorAll('code.demo').forEach(el => {
const targetContainer = document.createElement('div');
targetContainer.classList.toggle('light', el.classList.contains('light'));
targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;
const escapedText = el.textContent.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;').replace(/'/g, '&#039;');
targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${escapedText}</div>`;
el.parentElement.after(targetContainer);
// Extract and evaluate <script> tags
const scriptTags = targetContainer.getElementsByTagName('script');
Copilot is powered by AI and may make mistakes. Always verify output.
@mokimo mokimo temporarily deployed to milo_pr_merge July 8, 2025 09:19 — with GitHub Actions Inactive
@afmicka afmicka temporarily deployed to milo_pr_merge July 8, 2025 10:13 — with GitHub Actions Inactive
…ck (#4485)

* fixed modal reopening, and duplications

* moved comments to a separate file

* fixed the modal reopening issue

* updated unit test

* fixed multiple btn clicks

* corrected variable name
* [MWPW-174959] - table border update

* [MWPW-174959] - table rtl border update

* [MWPW-174959] - table update logic

* [MWPW-174959] - table update border logic mobile

* [MWPW-174959] - code optimization

* [MWPW-174959] - table border logic update

* [MWPW-174959] - table one heading border fix
* 3in1 spinner center position

* spinner update

---------

Co-authored-by: Predrag Markovic <cod14230@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0