8000 Appending link group classes instead of replacing by bandana147 · Pull Request #4503 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Appending link group classes instead of replacing #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

Conversation

bandana147
Copy link
Contributor
@bandana147 bandana147 commented Jul 7, 2025
  • mobile-only class was getting removed since we were picking only the last class item
  • Fixed by appending all authored classes

Resolves: MWPW-175933
https://jira.corp.adobe.com/browse/MWPW-175708

Test URLs:

QA

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@bandana147 bandana147 requested a review from a team as a code owner July 7, 2025 04:34
@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Jul 7, 2025
Copy link
Contributor
aem-code-sync bot commented Jul 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bandana147 bandana147< 8000 /a> added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jul 7, 2025
@bandana147
Copy link
Contributor Author

Marking this as high priority, as it could lead to a production issue if any extra classes are added to a link group. Like it happened for adobe home.

Copy link
Contributor
github-actions bot commented Jul 8, 2025

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@spadmasa
Copy link
spadmasa commented Jul 8, 2025

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Jul 8, 2025
@milo-pr-merge milo-pr-merge bot merged commit b1037a9 into stage Jul 8, 2025
30 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-175933 branch July 8, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0