8000 switched between portrait and landscape without refresh the gap is seen by patel-prince · Pull Request #4498 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

switched between portrait and landscape without refresh the gap is seen #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

switched between portrait and landscape without refresh the gap is seen #4498

merged 1 commit into from
Jul 8, 2025
+1 −0

Conversation

patel-prince
Copy link
Contributor
@patel-prince patel-prince commented Jul 2, 2025 •
edited by github-actions bot
Loading

when promobar is present and switched between portrait and landscape without refresh the gap is seen

Resolves: MWPW-175590

Test URLs:

QA URL:

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@patel-prince patel-prince requested a review from a team as a code owner July 2, 2025 07:11
@aem-code-sync AEM Code Sync
Copy link
Contributor
aem-code-sync bot commented Jul 2, 2025 •
edited
Loading
Page Scores Audits Google
📱 /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/blaishram/test-urls/page-with-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@narcis-radu
Copy link
Contributor

@adobecom/feds - can you take a look?

@patel-prince patel-prince requested a review from a team July 3, 2025 04:56
@prativas22
Copy link

Verified the PR fix for the gap that appears when the promobar is present and switch between portrait and landscape mode without refreshing.

https://main--homepage--adobecom.aem.live/fr/homepage/index-loggedout?milolibs=mwpw-175590--milo--patel-prince
https://main--cc--adobecom.aem.live/pl/creativecloud?milolibs=mwpw-175590--milo--patel-prince
image
image
https://main--cc--adobecom.aem.live/jp/creativecloud?milolibs=mwpw-175590--milo--patel-prince
image
image

The results of the QA test are included in the ticket for reference.
https://jira.corp.adobe.com/browse/MWPW-175590

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage labels Jul 3, 2025
@patel-prince patel-prince removed the request for review from a team July 3, 2025 11:13
@milo-pr-merge milo-pr-merge bot merged commit f9fbf18 into adobecom:stage Jul 8, 2025
21 of 22 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deva309 Deva309 Deva309 approved these changes

@nishantka nishantka nishantka approved these changes

@robert-bogos robert-bogos robert-bogos approved these changes

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@patel-prince @narcis-radu @prativas22 @Deva309 @nishantka @robert-bogos @spadmasa
0