8000 MWPW-169236 [Merch Cards] Support for Volume Discount Flex Promos by bozojovicic · Pull Request #4517 · adobecom/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MWPW-169236 [Merch Cards] Support for Volume Discount Flex Promos #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: stage
Choose a base branch
from

Conversation

bozojovicic
Copy link
Contributor
@bozojovicic bozojovicic commented Jul 8, 2025

This is continuation of my work on #4501 which is closed now. My changes :

  • in merch-card when quantity is changed, the quantity parameter is set also on prices and not only on CTAs
  • in checkout-mixin I added the method removePromoIfQuantityNotMet() which removes the promotion code from options if the selected quantity is smaller than minQuantity in the price offer
  • in inline-price we do the same by calling the same method but now we are also observing changes on data-quantity

Resolves: MWPW-169236

Test URLs:

Copy link
Contributor
aem-code-sync bot commented Jul 8, 2025
Page Scores Audits Google
📱 /drafts/bozo/qs-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/bozo/qs-promo?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0