-
Notifications
You must be signed in to change notification settings - Fork 191
MWPW-156867 [MILO][MEP][ANALYTICS] Support Column nicknames #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mepstage #3510 +/- ##
============================================
- Coverage 96.47% 96.46% -0.01%
============================================
Files 260 260
Lines 60582 60589 +7
============================================
+ Hits 58444 58446 +2
- Misses 2138 2143 +5 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
* MWPW-166355 [MEP] Number and symbols are very small in MEP button on RTL pages (#3541) update font family * MWPW-166002 | [MEP] Use Target served version of manifest in prod when Target experience is chosen (#3527) * Added server vs target manifest handling * refactored a bit * refactored test --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-159369 [cc][LANA] Error reported: target response time: 0.5 (#3475) * add sample rate * change error type * MWPW-156867 [MILO][MEP][ANALYTICS] Support Column nicknames (#3510) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * create mepxlg branch * update library * require full hostname match * update reference for unit test * update unit tests * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * add federated link function to registerInBlockActions * add to unit test * initial commit * stash commit * remove dupe valMap const * update test files * linting error fix --------- Co-authored-by: vgoodric <vgoodric@adobe.com> * MWPW-166639 [MEP] Removing OST links doesn't work when MEP button is on (#3556) exclude ost links from highlight --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com>
When a MEP manifest is active on a page, MEP experience related daa-lh (link hierarchy) attributes are automatically appended to the daa-lh values of divs that contain blocks (like marquees or asides, but not regular sections) using the following syntax:
...|manifest experience name|manifest name
These names can become very long, and this PR introduces the ability to create nicknames that can be set in a MEP manifest and seen in the daa-lh values on the page.
Resolves: MWPW-156867
On testing:
We are using this manifest to test various experience names:
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/nickname-manifest.json
Check the actual experience names to determine if the daa-lh works as intended. Some of the links include adobe target links, as well as params (we did not include actual targeting for entitlements or device type as we assume those values will work if params work).
Test URLs:
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?at_preview_token=dgtyOXLofIz_VnSNgEJbtg&at_preview_index=1_1&at_preview_listed_activities_only=true&at_preview_evaluate_as_true_audience_ids=1062165
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?at_preview_token=dgtyOXLofIz_VnSNgEJbtg&at_preview_index=1_2&at_preview_listed_activities_only=true&at_preview_evaluate_as_true_audience_ids=1062165
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?at_preview_token=dgtyOXLofIz_VnSNgEJbtg&at_preview_index=1_3&at_preview_listed_activities_only=true&at_preview_evaluate_as_true_audience_ids=1062165
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?nickname=true
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?nickname=false
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?nickname=start
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?nickname=double
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?nickname=end
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&at_preview_token=dgtyOXLofIz_VnSNgEJbtg&at_preview_index=1_1&at_preview_listed_activities_only=true&at_preview_evaluate_as_true_audience_ids=1062165
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&at_preview_token=dgtyOXLofIz_VnSNgEJbtg&at_preview_index=1_2&at_preview_listed_activities_only=true&at_preview_evaluate_as_true_audience_ids=1062165
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&at_preview_token=dgtyOXLofIz_VnSNgEJbtg&at_preview_index=1_3&at_preview_listed_activities_only=true&at_preview_evaluate_as_true_audience_ids=1062165
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&nickname=true
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&nickname=false
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&nickname=start
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&nickname=double
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepnickname/?milolibs=experience-nicknames&nickname=end
psi-check:
https://experience-nicknames--milo--adobecom.hlx.live/