MWPW-166639 [MEP] Removing OST links doesn't work when MEP button is on #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mepstage #3556 +/- ##
=========================================
Coverage 96.50% 96.50%
=========================================
Files 260 260
Lines 60780 60780
=========================================
Hits 58656 58656
Misses 2124 2124 ☔ View full report in Codecov by Sentry. |
denlight
approved these changes
Jan 28, 2025
markpadbe
approved these changes
Jan 28, 2025
AdobeLinhart
approved these changes
Jan 28, 2025
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
* MWPW-166355 [MEP] Number and symbols are very small in MEP button on RTL pages (#3541) update font family * MWPW-166002 | [MEP] Use Target served version of manifest in prod when Target experience is chosen (#3527) * Added server vs target manifest handling * refactored a bit * refactored test --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> * MWPW-159369 [cc][LANA] Error reported: target response time: 0.5 (#3475) * add sample rate * change error type * MWPW-156867 [MILO][MEP][ANALYTICS] Support Column nicknames (#3510) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * create mepxlg branch * update library * require full hostname match * update reference for unit test * update unit tests * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * add federated link function to registerInBlockActions * add to unit test * initial commit * stash commit * remove dupe valMap const * update test files * linting error fix --------- Co-authored-by: vgoodric <vgoodric@adobe.com> * MWPW-166639 [MEP] Removing OST links doesn't work when MEP button is on (#3556) exclude ost links from highlight --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: Jan Ivan Viloria <158211769+ivanvatadobe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description:
When in preview mode, removed elements are not actually removed, but rather tagged to be hidden and highlighted when toggled by the highlight checkbox in the MEP button. Because ost links are replaced by M@S, they lose the attribute to show them as hidden, thus making it impossible to tell they will be removed in production.
................................
URL: https://main--cc--adobecom.hlx.page/drafts/fredw/try-buy-test/catalog?mep=%2Fdrafts%2Fpromos%2F2025%2Fglobal%2Ffred-test-try-buy.json--secondary-cta
................................
Steps to Reproduce:
Expected Results: Free trial button is removed
................................
Actual Results: Free trail buttons is not removed
Resolves: MWPW-166639
Test URLs: