[MWPW-175541] Improve Unit Tests #496
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
* stage: IMS error logging improvement - Phase 1 (#493) [MWPW-173462] Loading screen: Text should not be marked as a heading (#487) Allow empty query (#488) Sending error object in addition to error message in case of IMS token failures (#486) [MWPW-174632] Getting 'unable to process the request' error toast for 'Empty File + Max File Size' upload for 2b/2c (#476) [MWPW-171797] Introduce timeout to all fetch calls being made (#484) Fix for workflow getting stuck at transition screen if asset api fails (#481) Fix CSS issues found during launch (#482) [MWPW-174834] Added pdf file support in ocr. Was a miss from the last PR. (#483) [MWPW-174834] Fallback to file extension if MIME type is absent for determining file type (#480) [MWPW-174783] Fix error message issue on Japanese page (#478) [MWPW-172186] Phase 2 of accessibility fix for transition screen (#460) # Conflicts: # unitylibs/core/workflow/workflow-acrobat/action-binder.js # unitylibs/utils/FileUtils.js
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 198 to 199 in c008dbf
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'error_generic' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_loading_verb_limits' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_empty_verb_limits' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_renaming_file' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_error_fetch_redirect_url' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_validate_files' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_unsupported_type' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_empty_file' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_too_large' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_only_accept_one_file' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_same_type' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_unsupported_type_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_empty_file_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_too_large_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_multiple_invalid_files' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_max_num_files' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_same_type_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_max_page_count' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_min_page_count' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_verify_page_count' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_max_page_count_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_duplicate_asset' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_max_quota_exceeded' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_no_storage_provision' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_chunk_upload' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_finalize_asset' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_redirect_to_app' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_warn_chunk_upload' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_warn_renamed_invalid_file_name' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'warn_delete_asset' found.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 345 to 346 in c008dbf
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 384 to 385 in c008dbf
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
There should be no space before ','.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 426 to 427 in c008dbf
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 466 to 467 in c008dbf
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 628 to 631 in c008dbf
🚫 [eslint] <eol-last> reported by reviewdog 🐶
Newline required at end of file but not found.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
More than 1 blank line not allowed.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 51 to 52 in c008dbf
🚫 [eslint] <no-plusplus> reported by reviewdog 🐶
Unary operator '++' used.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 109. Maximum allowed is 100.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-loop-func> reported by reviewdog 🐶
Function declared in a loop contains unsafe references to variable(s) 'retryDelay'.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
🚫 [eslint] <operator-assignment> reported by reviewdog 🐶
Assignment (=) can be replaced with operator assignment (+=).
🚫 [eslint] <prefer-template> reported by reviewdog 🐶
Unexpected string concatenation.
🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Expected property shorthand.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 88 to 89 in c008dbf
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 112 to 116 in c008dbf
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Expected to return a value at the end of async arrow function.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 142. Maximum allowed is 100.
🚫 [eslint] <radix> reported by reviewdog 🐶
Missing radix parameter.
🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Expected property shorthand.
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'timeoutId' was used before it was defined.
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 368 to 372 in c008dbf
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 375 to 379 in c008dbf
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 380 to 384 in c008dbf
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 446 to 447 in c008dbf
🚫 [eslint] <prefer-template> reported by reviewdog 🐶
Unexpected string concatenation.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 133. Maximum allowed is 100.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 111. Maximum allowed is 100.
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'attemptMap' is assigned a value but never used.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 143. Maximum allowed is 100.
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space after =>.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-return-await> reported by reviewdog 🐶
Redundant use of await on a return value.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'allVerified' is assigned a value but never used.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 117. Maximum allowed is 100.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 614 to 615 in c008dbf
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 630 to 631 in c008dbf
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 651 to 656 in c008dbf
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 128. Maximum allowed is 100.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 137. Maximum allowed is 100.
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'fileData' is never reassigned. Use 'const' instead.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
| @@ -87,16 +87,22 @@ describe('Headers and Token', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('Should return headers with empty string if refresh token fails', async () => { | |||
| it('Should return headers with empty string if refresh token fails', async function () { | |||
There was a problem hiding this comment.
Unexpected unnamed async function.
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_unsupported_type' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_empty_file' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_too_large' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_only_accept_one_file' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_same_type' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_unsupported_type_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_empty_file_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_too_large_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_multiple_invalid_files' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_max_num_files' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'validation_error_file_same_type_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_max_page_count' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_min_page_count' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_verify_page_count' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_max_page_count_multi' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_validation_error_duplicate_asset' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_max_quota_exceeded' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_no_storage_provision' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_chunk_upload' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_finalize_asset' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_error_redirect_to_app' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'upload_warn_chunk_upload' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pre_upload_warn_renamed_invalid_file_name' found.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'warn_delete_asset' found.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 345 to 346 in 92d6b8f
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 384 to 385 in 92d6b8f
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
There should be no space before ','.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 426 to 427 in 92d6b8f
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 466 to 467 in 92d6b8f
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <comma-spacing> reported by reviewdog 🐶
A space is required after ','.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/action-binder.js
Lines 628 to 631 in 92d6b8f
🚫 [eslint] <eol-last> reported by reviewdog 🐶
Newline required at end of file but not found.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
More than 1 blank line not allowed.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 51 to 52 in 92d6b8f
🚫 [eslint] <no-plusplus> reported by reviewdog 🐶
Unary operator '++' used.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 109. Maximum allowed is 100.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-loop-func> reported by reviewdog 🐶
Function declared in a loop contains unsafe references to variable(s) 'retryDelay'.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <no-promise-executor-return> reported by reviewdog 🐶
Return values from promise executor functions cannot be read.
🚫 [eslint] <operator-assignment> reported by reviewdog 🐶
Assignment (=) can be replaced with operator assignment (+=).
🚫 [eslint] <prefer-template> reported by reviewdog 🐶
Unexpected string concatenation.
🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Expected property shorthand.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 88 to 89 in 92d6b8f
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 112 to 116 in 92d6b8f
🚫 [eslint] <consistent-return> reported by reviewdog 🐶
Expected to return a value at the end of async arrow function.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 142. Maximum allowed is 100.
🚫 [eslint] <radix> reported by reviewdog 🐶
Missing radix parameter.
🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Expected property shorthand.
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'timeoutId' was used before it was defined.
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 368 to 372 in 92d6b8f
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'if' condition.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 375 to 379 in 92d6b8f
🚫 [eslint] <curly> reported by reviewdog 🐶
Expected { after 'else'.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 380 to 384 in 92d6b8f
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 446 to 447 in 92d6b8f
🚫 [eslint] <prefer-template> reported by reviewdog 🐶
Unexpected string concatenation.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 133. Maximum allowed is 100.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 111. Maximum allowed is 100.
🚫 [eslint] <one-var> reported by reviewdog 🐶
Split 'let' declarations into multiple statements.
🚫 [eslint] <one-var-declaration-per-line> reported by reviewdog 🐶
Expected variable declaration to be on a new line.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'attemptMap' is assigned a value but never used.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 143. Maximum allowed is 100.
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space after =>.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-return-await> reported by reviewdog 🐶
Redundant use of await on a return value.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'allVerified' is assigned a value but never used.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 117. Maximum allowed is 100.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 8 spaces but found 10.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
🚫 [eslint] <arrow-parens> reported by reviewdog 🐶
Expected parentheses around arrow function argument.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 614 to 615 in 92d6b8f
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 630 to 631 in 92d6b8f
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
unity/unitylibs/core/workflow/workflow-acrobat/upload-handler.js
Lines 651 to 656 in 92d6b8f
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 128. Maximum allowed is 100.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 137. Maximum allowed is 100.
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'fileData' is never reassigned. Use 'const' instead.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <max-len> reported by reviewdog 🐶
This line has a length of 101. Maximum allowed is 100.
|
@rohitsahu Please reference the following ticket in the PR title and description. |
| describe('createActionBtn', () => { | ||
| it('should create a button with text', async () => { | ||
| const btnCfg = document.createElement('div'); | ||
| btnCfg.innerText = 'Test Button'; | ||
| const btn = await utils.createActionBtn(btnCfg, 'test-class'); | ||
| expect(btn).to.be.instanceOf(HTMLElement); | ||
| expect(btn.className).to.include('test-class'); | ||
| expect(btn.textContent).to.include('Test Button'); | ||
| }); | ||
| it('should prepend text if swapOrder is true', async () => { | ||
| const btnCfg = document.createElement('div'); | ||
| btnCfg.innerText = 'Test Button'; | ||
| const btn = await utils.createActionBtn(btnCfg, 'test-class', false, true); | ||
| expect(btn.firstChild.className).to.include('btn-text'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('showErrorToast', () => { | ||
| let fetchStub; | ||
| let origImport; | ||
| beforeEach(() => { | ||
| fetchStub = sinon.stub(window, 'fetch'); | ||
| fetchStub.onFirstCall().resolves({ text: () => Promise.resolve('<svg>alert</svg>') }); | ||
| fetchStub.onSecondCall().resolves({ text: () => Promise.resolve('<svg>close</svg>') }); | ||
| origImport = window.import; | ||
| window.import = () => Promise.resolve({ decorateDefaultLinkAnalytics: sinon.stub() }); | ||
| }); | ||
| afterEach(() => { | ||
| fetchStub.restore(); | ||
| window.import = origImport; | ||
| }); | ||
| it('should append error toast if not present and set message', async () => { | ||
| const targetEl = document.createElement('div'); | ||
| const unityEl = document.createElement('div'); | ||
| const msgEl = document.createElement('span'); | ||
| msgEl.textContent = 'Error message'; | ||
| unityEl.appendChild(document.createElement('div')); | ||
| unityEl.appendChild(msgEl); | ||
| unityEl.querySelector = () => unityEl.children[0]; | ||
| document.body.innerHTML = '<div class="unity-enabled"><div class="interactive-area"><div class="alert-holder"><div class="alert-toast"><div class="alert-text"><p></p></div></div></div></div></div>'; | ||
| await utils.showErrorToast(targetEl, unityEl, 'div'); | ||
| const p = document.querySelector('.unity-enabled .interactive-area .alert-holder .alert-toast .alert-text p'); | ||
| expect(p.innerText).to.equal('Error message'); | ||
| const holder = document.querySelector('.unity-enabled .interactive-area .alert-holder'); | ||
| expect(holder.style.display).to.equal('flex'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Just adding a note that these will most likely need to be removed later once these Ps-specific functions are removed from our utils file.
|
I see Nala tests are currently failing with this PR. Could you please look into this? |
Done |
There was a problem hiding this comment.
Unexpected unnamed function.
| const coverageFile = path.join(__dirname, '..', 'coverage', 'lcov.info'); | ||
|
|
||
| if (!fs.existsSync(coverageFile)) { | ||
| console.error('❌ Coverage file not found. Run tests with coverage first.'); |
There was a problem hiding this comment.
Unexpected console statement.
|
|
||
| const coverage = parseLcovFile(coverageFile); | ||
|
|
||
| console.log('📊 Coverage Report:'); |
There was a problem hiding this comment.
Unexpected console statement.
| const coverage = parseLcovFile(coverageFile); | ||
|
|
||
| console.log('📊 Coverage Report:'); | ||
| console.log(` Lines: ${coverage.lines.hit}/${coverage.lines.total} (${coverage.lines.percentage.toFixed(2)}%)`); |
There was a problem hiding this comment.
Unexpected console statement.
|
|
||
| console.log('📊 Coverage Report:'); | ||
| console.log(` Lines: ${coverage.lines.hit}/${coverage.lines.total} (${coverage.lines.percentage.toFixed(2)}%)`); | ||
| console.log(` Functions: ${coverage.functions.hit}/${coverage.functions.total} (${coverage.functions.percentage.toFixed(2)}%)`); |
There was a problem hiding this comment.
Unexpected console statement.
| console.log('📊 Coverage Report:'); | ||
| console.log(` Lines: ${coverage.lines.hit}/${coverage.lines.total} (${coverage.lines.percentage.toFixed(2)}%)`); | ||
| console.log(` Functions: ${coverage.functions.hit}/${coverage.functions.total} (${coverage.functions.percentage.toFixed(2)}%)`); | ||
| console.log(` Branches: ${coverage.branches.hit}/${coverage.branches.total} (${coverage.branches.percentage.toFixed(2)}%)`); |
There was a problem hiding this comment.
Unexpected console statement.
| const overallCoverage = coverage.lines.percentage; | ||
|
|
||
| if (overallCoverage >= COVERAGE_THRESHOLD) { | ||
| console.log(`✅ Coverage ${overallCoverage.toFixed(2)}% meets the required ${COVERAGE_THRESHOLD}% threshold`); |
There was a problem hiding this comment.
Unexpected console statement.
| console.log(`✅ Coverage ${overallCoverage.toFixed(2)}% meets the required ${COVERAGE_THRESHOLD}% threshold`); | ||
| process.exit(0); | ||
| } else { | ||
| console.log(`❌ Coverage ${overallCoverage.toFixed(2)}% is below the required ${COVERAGE_THRESHOLD}% threshold`); |
There was a problem hiding this comment.
Unexpected console statement.
| process.exit(0); | ||
| } else { | ||
| console.log(`❌ Coverage ${overallCoverage.toFixed(2)}% is below the required ${COVERAGE_THRESHOLD}% threshold`); | ||
| console.log(` Need ${(COVERAGE_THRESHOLD - overallCoverage).toFixed(2)}% more coverage to pass`); |
There was a problem hiding this comment.
Unexpected console statement.
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
* stage: [MWPW-174041] : Generic method to parse the error object (including nested error object) and flatten it to be logged in splunk incase of ims token failure (#497) [MWPW-175541] Improve Unit Tests (#496) [MWPW-175937] Unity linting fixes (#495) [NALA]UI Automation tests scripts for batch 2A verbs (#491) [MWPW-174048] Remove close icon from prompt suggestion dropdown (#492) IMS error logging improvement - Phase 1 (#493) [MWPW-173462] Loading screen: Text should not be marked as a heading (#487) Allow empty query (#488) Sending error object in addition to error message in case of IMS token failures (#486) [MWPW-174632] Getting 'unable to process the request' error toast for 'Empty File + Max File Size' upload for 2b/2c (#476) [MWPW-171797] Introduce timeout to all fetch calls being made (#484) # Conflicts: # unitylibs/core/workflow/workflow-acrobat/action-binder.js # unitylibs/core/workflow/workflow-acrobat/upload-handler.js
* stage: [MWPW-173999] [MWPW-174144] Add additional headers (#457) [MWPW-174041] : Generic method to parse the error object (including nested error object) and flatten it to be logged in splunk incase of ims token failure (#497) [MWPW-175541] Improve Unit Tests (#496) [MWPW-175937] Unity linting fixes (#495) [NALA]UI Automation tests scripts for batch 2A verbs (#491) [MWPW-174048] Remove close icon from prompt suggestion dropdown (#492) IMS error logging improvement - Phase 1 (#493) # Conflicts: # unitylibs/core/workflow/workflow-acrobat/action-binder.js
* Overall Unit test coverage increased to 80% from 67% * Written unit tests for acrobat workflows and common code.
- #457 - #497 - #496 - #495 - #491 - #492 - #493 **Test URLs:** CC - Before: https://main--cc--adobecom.hlx.live/products/photoshop/online?unitylibs=main - After: https://main--cc--adobecom.hlx.live/products/photoshop/online?unitylibs=stage DC - Before: https://main--dc--adobecom.hlx.live/acrobat/online/compress?unitylibs=main - After: https://main--dc--adobecom.hlx.live/acrobat/online/compress?unitylibs=stage
Before:
Resolves: MWPW-175541
Test URLs: