Append the tags #2731
Merged
Append the tags #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances how tags are appended to collections by filtering out ignored keys, updating the Mongo update operations to add new tags without duplicates, and normalizing CollectionTags equality logic.
- Refactors
getPreservedTagsto skip specific tag keys and returns only the incoming tags - Changes Mongo updates from
settoaddEachToSetto avoid overwriting existing tags - Updates
CollectionTags’sequals/hashCodeto ignore the timestamp and removes unused imports
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| libs/utils/src/main/java/com/akto/data_actor/DbLayer.java | Filters out ignored tag keys and uses addEachToSet for updates |
| libs/dao/src/main/java/com/akto/dto/traffic/CollectionTags.java | Cleans unused imports and aligns equals/hashCode on key/value/source only |
Comments suppressed due to low confidence (1)
libs/dao/src/main/java/com/akto/dto/traffic/CollectionTags.java:46
- Consider adding unit tests for
equalsandhashCodeto ensure consistency and validate that tags are compared correctly now thatlastUpdatedTsis excluded.
public boolean equals(Object obj) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ayushaga14
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the tags of all the service where the request was incoming.