Revert "Append the tags" #2732
Revert "Append the tags" #2732
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previous “Append the tags” behavior by introducing a new getPreservedTags method to merge existing and incoming tags and switching MongoDB tag updates from addEachToSet to a full set.
- Replace
getFilteredTagswithgetPreservedTags(apiCollection, tags)that preserves non-KUBERNETES tags and merges them with the new list. - Change MongoDB updates in
DbLayerto useUpdates.setinstead ofUpdates.addEachToSet. - Update
CollectionTags’s hashCode implementation and remove the custom equals override.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/utils/src/main/java/com/akto/data_actor/DbLayer.java | Renamed and rewrote filtering logic, updated update calls. |
| libs/dao/src/main/java/com/akto/dto/traffic/CollectionTags.java | Removed equals, adjusted hashCode, added unused imports. |
Comments suppressed due to low confidence (1)
libs/utils/src/main/java/com/akto/data_actor/DbLayer.java:493
- [nitpick] Using
addAllcan introduce duplicate tags since the MongoDB update now uses$set. If duplicates are undesirable, consider using a Set to dedupe or switch back to an additive operator likeaddEachToSet.
preservedTags.addAll(tags);
| @@ -39,17 +43,7 @@ public enum TagSource { | |||
|
|
|||
| @Override | |||
| public int hashCode() { | |||
There was a problem hiding this comment.
The custom equals override was removed but hashCode remains overridden, breaking the equals/hashCode contract. Reintroduce a matching equals method or remove the custom hashCode to maintain consistency.
Copilot uses AI. Check for mistakes.
| @@ -8,7 +8,11 @@ | |||
| import java.util.Objects; | |||
|
|
|||
| import com.akto.dao.context.Context; | |||
| import com.fasterxml.jackson.core.JsonProcessingException; | |||
There was a problem hiding this comment.
[nitpick] Several imports (JsonProcessingException, ObjectMapper, BasicDBObject) are not used. Consider removing them to keep the code clean.
Copilot uses AI. Check for mistakes.
Reverts #2731