8000 Lazy tardis ticking by DrTheodor · Pull Request #1509 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Lazy tardis ticking #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

Lazy tardis ticking #1509

merged 3 commits into from
Apr 30, 2025

Conversation

DrTheodor
Copy link
Member
@DrTheodor DrTheodor commented Apr 29, 2025 •
edited by duzos
Loading

About the PR

This PR adds lazy tardis ticking.

Why / Balance

Previously, the tardises would tick in any condition, even if they are not loaded outside or inside. Now they don't!

Technical details

Besides that, the PR fixes AIT to lazily load the world instead of getting it loaded right away. Unfortunately, as of the currently used version of multidim this won't actually guarantee lazy world loading.

Requirements

Breaking changes

  • TardisDesktop#getInteriorWorld -> TardisDesktop#worldRef

Changelog

🆑

  • perf: improved ticking large amounts of tardises

@DrTheodor DrTheodor added T: Performance Type: Performance impacting changes or bugs. S: Requires Lib PR Status: Requires a change to one of the used libraries, for which there is no open PR currently. S: Needs Lib Update Status: Requires a newer version of one of the libraries. S: Needs Lib PR Merged Status: Requires an existing library PR to be merged first. A: Tardis Components Area: Tardis components & manager. A: Core Tech Area: Underlying core tech for the mod and the Github repository. labels Apr 29, 2025
@DrTheodor DrTheodor requested a review from a team as a code owner April 29, 2025 10:41
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted. size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Console Area: Tardis console. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Apr 29, 2025
@GSMPBot GSMPBot requested a review from duzos April 29, 2025 10:42
duzos
duzos approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member
@duzos duzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Apr 30, 2025
@duzos
Copy link
Member
duzos commented Apr 30, 2025

however this isnt a "fix" its a "perf"

@Loqor Loqor self-requested a review April 30, 2025 17:11
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label Apr 30, 2025
@duzos duzos merged commit 3cdec60 into main Apr 30, 2025
6 checks passed
@duzos duzos deleted the lazy-tardis-ticking branch April 30, 2025 17:19
This was referenced May 7, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duzos duzos duzos approved these changes

@Loqor Loqor Awaiting requested review from Loqor

Assignees
No one assigned
Labels
A: Console Area: Tardis console. A: Core Tech Area: Underlying core tech for the mod and the Github repository. A: Tardis Components Area: Tardis components & manager. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Lib PR Merged Status: Requires an existing library PR to be merged first. S: Needs Lib Update Status: Requires a newer version of one of the libraries. S: Needs Review Status: Requires additional reviews before being fully accepted. S: Requires Lib PR Status: Requires a change to one of the used libraries, for which there is no open PR currently. size/M Denotes a PR that changes 100-999 lines. T: Performance Type: Performance impacting changes or bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrTheodor @duzos
0