8000 make tardis worlds tick lazily by DrTheodor · Pull Request #1546 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

make tardis worlds tick lazily #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

make tardis worlds tick lazily #1546

merged 1 commit into from
May 8, 2025

Conversation

DrTheodor
Copy link
Member

About the PR

This PR makes it so tardis worlds tick with the tardises they are linked to.

Why / Balance

For performance, of course!

Technical details

This PR utilizes the ServerTardis#shouldTick method, which was implemented in #1509.

Requirements

Changelog

🆑

  • fix: tardis' interior no longer ticks if no one is inside or outside (or if the tardis' interior chunks aren't loaded).

@DrTheodor DrTheodor self-assigned this May 8, 2025
@DrTheodor DrTheodor requested a review from a team as a code owner May 8, 2025 11:51
@DrTheodor DrTheodor added T: Performance Type: Performance impacting changes or bugs. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Tardis Components Area: Tardis components & manager. A: Core Tech Area: Underlying core tech for the mod and the Github repository. labels May 8, 2025
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels May 8, 2025
@GSMPBot GSMPBot requested review from Loqor, MaketendoDev and duzos May 8, 2025 11:51
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label May 8, 2025
@DrTheodor DrTheodor removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 8, 2025
@DrTheodor DrTheodor merged commit 72654b0 into main May 8, 2025
10 checks passed
@DrTheodor DrTheodor deleted the fix/lazy-interior-ticking branch May 8, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loqor Loqor Awaiting requested review from Loqor

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

@duzos duzos Awaiting requested review from duzos

Assignees

@DrTheodor DrTheodor

Labels
A: Core Tech Area: Underlying core tech for the mod and the Github repository. A: Tardis Components Area: Tardis components & manager. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Performance Type: Performance impacting changes or bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DrTheodor
0