8000 Add additional DB archive decompressors by wagoodman · Pull Request #657 · anchore/grype · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add additional DB archive decompressors #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2022
Merged

Add additional DB archive decompressors #657

merged 2 commits into from
Mar 7, 2022

Conversation

wagoodman
Copy link
Contributor

This PR does a couple things:

  • restores the original decompressors list to match that of hashicorp/go-getter used in the grype db update execution path
  • adds more decompressors to the grype db import path

This paves the way for replacing gzip DB archives for zstd DB archives in the future.

@wagoodman
restore getter decompressors and add more to import path
4b27e98 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman changed the title Restore getter decompressors and add more to import path Add additional DB archive decompressors Mar 6, 2022
@wagoodman wagoodman self-assigned this Mar 6, 2022
@wagoodman wagoodman requested a review from a team March 6, 2022 12:37
luhring
luhring approved these changes Mar 6, 2022
View reviewed changes
Copy link
Contributor
@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Excited about the performance improvement described in https://github.com/anchore/grype-db-builder/pull/176...

@wagoodman
source names from function call
e1b6d6e 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman merged commit 1368ea0 into main Mar 7, 2022
@wagoodman wagoodman deleted the restore-decompressors branch March 7, 2022 16:44
@wagoodman
Copy link
Contributor Author

@luhring same! We'll need to hold off until a new DB schema bump and tie archive formats to DB versions themselves since not all released versions of grype will be able to unarchive these additional formats.

@seiyab seiyab mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhring luhring luhring approved these changes

Assignees

@wagoodman wagoodman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @luhring
0