remove unused file internal/file/tar.go and its test #1724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seiya <20365512+seiyab@users.noreply.github.com>
46b5d79 to
5d55f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
internal/file/tar.go looks unused since #657.
Context
I scanned bugs similar to anchore/go-logger#13 just with curiosity and found that internal/file/tar.go has one (written file can be broken forgetting truncation). Investigating it, I also found that it isn't used. Running
git bisect run sh -c "git grep -q 'file.UnTarGz'", #657 looks to remove the last use of the file.