8000 Fix build on GitHub Actions for `lifecycle`, `navigation` and `paging` by MGaetan89 · Pull Request #777 · androidx/androidx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix build on GitHub Actions for lifecycle, navigation and paging #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: androidx-main
Choose a base branch
from
Open

Fix build on GitHub Actions for lifecycle, navigation and paging #777

wants to merge 3 commits into from

Conversation

MGaetan89
Copy link
Contributor

Proposed Changes

  • Replace the fixed version dependency on androidx.window.extensions:extensions to use a project dependency in :window:window to fix unresolved references when building :lifecycle, :navigation and :paging.

  • Replace some project dependencies on :activity:activity with a pinned version to 1.10.1 to fix the resulting Type androidx.activity.ActivityViewModelLazyKt$viewModels$1 is defined multiple times error.

  • Add a step to free some spaces in the runner so every step can build.

Testing

Test: GitHub Actions pass for every supported module.

Issues Fixed

Fixes: N/A

@MGaetan89 MGaetan89 changed the title Update 🪟window to use the tip of :window:extensions:extensions Update :window:window to use the tip of :window:extensions:extensions May 23, 2025
@MGaetan89 MGaetan89 changed the title Update :window:window to use the tip of :window:extensions:extensions Fix build on GitHub Actions for lifecycler, navigation and paging May 23, 2025
@MGaetan89 MGaetan89 changed the title Fix build on GitHub Actions for lifecycler, navigation and paging Fix build on GitHub Actions for lifecycle, navigation and paging May 23, 2025
@MGaetan89
Copy link
Contributor Author

lifecycle and paging build successfully now on GitHub Actions, but navigation gets cancelled. I'm not sure why

@MGaetan89 MGaetan89 force-pushed the fix_presubmit_runs branch 2 times, most recently from a1092bb to 9eac9ca Compare May 28, 2025 05:05
@MGaetan89
Copy link
Contributor Author

Some builds fail again because Lifecycle 2.9.1 is not available yet (the update comes from 2bd44d6).

@MGaetan89 MGaetan89 force-pushed the fix_presubmit_runs branch 2 times, most recently from 45360f6 to 51ee0cc Compare June 4, 2025 17:43
@MGaetan89
Copy link
Contributor Author

Lifecycle 2.9.1 was released, so I've updated this PR, and the build is green(-ish) again

@MGaetan89 MGaetan89 force-pushed the fix_presubmit_runs branch 4 times, most recently from dfd6f93 to ebfebc1 Compare June 16, 2025 07:54
@MGaetan89 MGaetan89 force-pushed the fix_presubmit_runs branch 3 times, most recently from d328644 to 045cd2d Compare June 26, 2025 10:56
@MGaetan89 MGaetan89 force-pushed the fix_presubmit_runs branch from 045cd2d to 5a42f90 Compare June 27, 2025 04:30
@MGaetan89
Copy link
Contributor Author

The remaining failures are coming from Compose because of:

  • A Lint warning:
Lint found errors in the project; aborting build.

Fix the issues identified by lint, or add the issues to the lint baseline via `gradlew updateLintBaseline`.
For more details, see https://developer.android.com/studio/write/lint#snapshot

/home/runner/work/androidx/androidx/compose/material/material/samples/src/main/java/androidx/compose/material/samples/TabSamples.kt:375: Error: State backed values should use the lambda overload of Modifier.offset [UseOfNonLambdaOffsetOverload from androidx.compose.foundation]
                .offset(x = indicatorStart)
                 ~~~~~~

   Explanation for issues of type "UseOfNonLambdaOffsetOverload":
   Modifier.offset() is recommended to be used with static arguments only to
   avoid unnecessary recompositions. Modifier.offset{ } is preferred in the
   cases where the arguments are backed by a State.

   Vendor: Jetpack Compose
   Identifier: androidx.compose.foundation
   Feedback: https://issuetracker.google.com/issues/new?component=612128
  • A change in the API:
API definition has changed

Declared definition is /home/runner/work/androidx/androidx/compose/material3/material3-adaptive-navigation-suite/api/current.txt
True     definition is /home/runner/work/androidx/androidx/out/paging-playground/compose/material3/material3-adaptive-navigation-suite/build/api/current.txt

Please run `./gradlew updateApi` to confirm these changes are
intentional by updating the API definition.

Difference between these files:
92c92
<     method @BytecodeOnly @Deprecated @androidx.compose.runtime.Composable public static void NavigationSuiteScaffold-Fin9vsw(kotlin.jvm.functions.Function1!, androidx.compose.ui.Modifier!, String!, androidx.compose.material3.adaptive.navigationsuite.NavigationSuiteColors!, long, long, kotlin.jvm.functions.Function2!, androidx.compose.runtime.Composer!, int, int);
---
>     method @BytecodeOnly @androidx.compose.runtime.Composable public static void NavigationSuiteScaffold-Fin9vsw(kotlin.jvm.functions.Function1!, androidx.compose.ui.Modifier!, String!, androidx.compose.material3.adaptive.navigationsuite.NavigationSuiteColors!, long, long, kotlin.jvm.functions.Function2!, androidx.compose.runtime.Composer!, int, int);
103c103
<     method @BytecodeOnly @Deprecated @androidx.compose.runtime.Composable public static void NavigationSuiteScaffoldLayout-Yk5QHw8(kotlin.jvm.functions.Function2!, String!, kotlin.jvm.functions.Function2!, androidx.compose.runtime.Composer!, int, int);
---
>     method @BytecodeOnly @androidx.compose.runtime.Composable public static void NavigationSuiteScaffoldLayout-Yk5QHw8(kotlin.jvm.functions.Function2!, String!, kotlin.jvm.functions.Function2!, androidx.compose.runtime.Composer!, int, int);

@MGaetan89 MGaetan89 force-pushed the fix_presubmit_runs branch from 5a42f90 to a52a7fd Compare June 30, 2025 07:38
liutikas
liutikas reviewed Jun 30, 2025
View reviewed changes
window/window/build.gradle
@@ -94,8 +94,8 @@ dependencies {
androidTestImplementation(libs.truth)
androidTestImplementation(libs.junit) // Needed for Assert.assertThrows
androidTestImplementation(extensions_core_version)
androidTestImplementation(compileOnly(project(":window:sidecar:sidecar")))
androidTestImplementation(compileOnly(extensions_version))
androidTestImplementation(project(":window:sidecar:sidecar"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spotting. Will land this as r.android.com/3679958

@MGaetan89 MGaetan89 force-pushed the fix_presubmit_runs branch from a52a7fd to e193b57 Compare July 7, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liutikas liutikas liutikas left review comments

@jbw0033 jbw0033 Awaiting requested review from jbw0033 jbw0033 is a code owner

@ianhanniballake ianhanniballake Awaiting requested review from ianhanniballake ianhanniballake is a code owner

@claraf3 claraf3 Awaiting requested review from claraf3 claraf3 is a code owner

@dlam dlam Awaiting requested review from dlam dlam is a code owner

@yigit yigit Awaiting requested review from yigit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @liutikas
0