8000 Fix build on GitHub Actions for `lifecycle`, `navigation` and `paging` by MGaetan89 · Pull Request #777 · androidx/androidx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix build on GitHub Actions for lifecycle, navigation and paging #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: androidx-main
Choose a base branch
from
Open

Fix build on GitHub Actions for lifecycle, navigation and paging #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e613a77
Update `:window:window` to use the tip of `:window:extensions:extensi…
MGaetan89 May 22, 2025
9eb6ff5
Depend on Activity 1.10.1 in `:compose:integration-tests:demo` and `n…
MGaetan89 May 22, 2025
e193b57
Free some space on the runner
MGaetan89 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,17 @@ jobs:
DEVELOCITY_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
GRADLE_ENCRYPTION_KEY: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
steps:
- name: Free Disk Space
uses: jlumbroso/free-disk-space@main
if: runner.os == 'Linux'
with:
tool-cache: true
android: false
dotnet: true
haskell: true
large-packages: true
docker-images: true
swap-storage: true
- name: "Checkout androidx repo"
uses: actions/checkout@v4
- name: "Check if the project should be built"
Expand Down
2 changes: 1 addition & 1 deletion compose/integration-tests/demos/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies {
implementation(libs.kotlinReflect)
implementation(libs.kotlinStdlib)

implementation(project(":activity:activity"))
implementation("androidx.activity:activity:1.10.1")
implementation("androidx.core:core-ktx:1.15.0")
implementation(project(":compose:foundation:foundation"))
implementation(project(":compose:foundation:foundation-layout"))
Expand Down
2 changes: 1 addition & 1 deletion navigation/integration-tests/testapp/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dependencies {
implementation(project(":navigation:navigation-fragment"))
implementation(project(":navigation:navigation-runtime"))
implementation(project(":navigation:navigation-ui"))
implementation(project(":activity:activity"))
implementation("androidx.activity:activity:1.10.1")
implementation("androidx.appcompat:appcompat:1.1.0")
implementation("androidx.cardview:cardview:1.0.0")
implementation("androidx.constraintlayout:constraintlayout:2.0.1")
Expand Down
4 changes: 2 additions & 2 deletions window/window/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ dependencies {
androidTestImplementation(libs.truth)
androidTestImplementation(libs.junit) // Needed for Assert.assertThrows
androidTestImplementation(extensions_core_version)
androidTestImplementation(compileOnly(project(":window:sidecar:sidecar")))
androidTestImplementation(compileOnly(extensions_version))
androidTestImplementation(project(":window:sidecar:sidecar"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spotting. Will land this as r.android.com/3679958

androidTestImplementation(extensions_version)
}

androidx {
Expand Down
Loading
0