8000 waf_condition - adds missing options validation to filters by tremble · Pull Request #2220 · ansible-collections/community.aws · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

waf_condition - adds missing options validation to filters #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2025
Merged

waf_condition - adds missing options validation to filters #2220

merged 3 commits into from
Jan 27, 2025

Conversation

tremble
Copy link
Contributor
@tremble tremble commented Jan 27, 2025
SUMMARY

waf_condition - adds missing options validation to filters

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

waf_condition

ADDITIONAL INFORMATION

Arguably a breaking change, but behaviour would be a little erratic if bad options were passed.

@tremble tremble added the backport-9 PR should be backported to the stable-9 branch label Jan 27, 2025
@tremble tremble requested a review from abikouo January 27, 2025 13:16
@tremble tremble force-pushed the waf_condition/missing-option branch from a8babdd to 0a9dc91 Compare January 27, 2025 13:32
abikouo
abikouo reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor
@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex_pattern argument needs to be updated for the sanity tests to pass

@tremble
< 8000 div class="timeline-comment-header clearfix d-flex" data-morpheus-enabled="false">
Copy link
Contributor Author
tremble commented Jan 27, 2025

The regex_pattern argument needs to be updated for the sanity tests to pass

fixed

@tremble tremble requested a review from abikouo January 27, 2025 13:45
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ea1a11b6952d49658412ac66c32780ee

✔️ ansible-galaxy-importer SUCCESS in 3m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 15s
✔️ ansible-test-splitter SUCCESS in 4m 06s
Skipped 22 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 27, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ad27d32907044c4fb011d682ef1be26b

❌ ansible-galaxy-importer FAILURE in 4m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 28s
✔️ ansible-test-splitter SUCCESS in 3m 50s
Skipped 22 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 699539f into ansible-collections:main Jan 27, 2025
82 of 83 checks passed
@patchback Patchback
Copy link
patchback bot commented Jan 27, 2025 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/699539fb78ae3c96eb4bb489c1aa69674e686451/pr-2220

Backported as #2222

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 27, 2025
@tremble @patchback
waf_condition - adds missing options validation to filters (#2220)
39d4dc7 
SUMMARY
waf_condition - adds missing options validation to filters
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
waf_condition
ADDITIONAL INFORMATION
Arguably a breaking change, but behaviour would be a little erratic if bad options were passed.

Reviewed-by: Bikouo Aubin
(cherry picked from commit 699539f)
@patchback patchback bot mentioned this pull request Jan 27, 2025
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 27, 2025
@patchback
waf_condition - adds missing options validation to filters (#2220) (#…
4133f67 
…2222)

This is a backport of PR #2220 as merged into main (699539f).
SUMMARY
waf_condition - adds missing options validation to filters
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
waf_condition
ADDITIONAL INFORMATION
Arguably a breaking change, but behaviour would be a little erratic if bad options were passed.

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@markuman markuman Awaiting requested review from markuman

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
backport-9 PR should be backported to the stable-9 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @abikouo
0