[PR #2220/699539fb backport][stable-9] waf_condition - adds missing options validation to filters #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUMMARY waf_condition - adds missing options validation to filters ISSUE TYPE Feature Pull Request COMPONENT NAME waf_condition ADDITIONAL INFORMATION Arguably a breaking change, but behaviour would be a little erratic if bad options were passed. Reviewed-by: Bikouo Aubin (cherry picked from commit 699539f)
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 49s (non-voting) |
tremble
approved these changes
Jan 27, 2025
|
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 46s (non-voting) |
4133f67
into
stable-9
46 of 83 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2220 as merged into main (699539f).
SUMMARY
waf_condition - adds missing options validation to filters
ISSUE TYPE
COMPONENT NAME
waf_condition
ADDITIONAL INFORMATION
Arguably a breaking change, but behaviour would be a little erratic if bad options were passed.