8000 Fixed import exception when using pip 10+ by Xetius · Pull Request #931 · ansible/ansible-container · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 23, 2019. It is now read-only.

Fixed import exception when using pip 10+ #931

Closed
wants to merge 1 commit into from
Closed

Fixed import exception when using pip 10+ #931

wants to merge 1 commit into from

Conversation

Xetius
Copy link
@Xetius Xetius commented May 21, 2018
ISSUE TYPE
  • Bugfix Pull Request
SUMMARY

When attempting to install ansible-container using pip 10+ you get an exception.

Collecting ansible-container
  Using cached https://files.pythonhosted.org/packages/bc/2a/b1252de3931173d26a30fc965be33c9cc0044cf7b23ce4c707f55d86830c/ansible-container-0.9.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/ll/f9vvzm_j29zczm6j89vqclyw0000gn/T/pip-install-qTUFXW/ansible-container/setup.py", line 10, in <module>
        from pip.req import parse_requirements
    ImportError: No module named req

Added a check around the import to handle that parse_requirements are now in pip._internal.req, instead of pip.req.

This fixes the issue with the following pull request : pypa/pip#4700, which is not in pip 10+

@Voronenko Voronenko mentioned this pull request Jun 7, 2018
Closed
@gregdek
Copy link
Contributor
gregdek commented Jun 8, 2018

Fixed by #939 instead. Thanks!

@gregdek gregdek closed this Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xetius @gregdek
0