8000 Cumulative tests fix - lets get project great again (at least to green tests state) by Voronenko · Pull Request #939 · ansible/ansible-container · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 23, 2019. It is now read-only.

Cumulative tests fix - lets get project great again (at least to green tests state) #939

Merged
merged 8 commits into from
Jun 8, 2018
Merged

Cumulative tests fix - lets get project great again (at least to green tests state) #939

merged 8 commits into from
Jun 8, 2018

Conversation

Voronenko
Copy link
Contributor

Colleagues, lets leave develop branch in stable state with green tests at least.
It is too nice project to leave it in current "middle" state.

cc: @j00bar , @gregdek , @chouseknecht

ISSUE TYPE
  • Bugfix Pull Request
SUMMARY
  1. Fixed travis tests to green state - we have a deadly red line for a while
  2. safe characters filtering for role name in edge cases
  3. Amazon:2 tests - added tar which is now absent in base image
  4. Workaround for non-english file names if any
  5. Pinned docker version to prevent breakage for 3.x.x changes
  6. Support for PIP 10

Changes are UP and green:

https://travis-ci.com/softasap/ansible-container/builds/75429794

@Voronenko Voronenko mentioned this pull request Jun 5, 2018
Closed
@gregdek gregdek requested a review from j00bar June 6, 2018 07:29
@Voronenko Voronenko mentioned this pull request Jun 7, 2018
Closed
@gregdek
Copy link
Contributor
gregdek commented Jun 8, 2018

OK, my cursory review plus passing tests tells me that this is good, so I'm gonna go ahead and merge this. Thanks @Voronenko for this work, much appreciated.

@gregdek gregdek merged commit 9250b44 into ansible:develop Jun 8, 2018
This was referenced Jun 8, 2018
Closed
Closed
Closed
Closed
@Voronenko Voronenko deleted the regression-test-fixes branch June 8, 2018 15:40
@Voronenko Voronenko mentioned this pull request Jun 26, 2018
Closed
@Voronenko Voronenko mentioned this pull request Jul 18, 2018
Open
@Voronenko Voronenko mentioned this pull request Dec 13, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j00bar j00bar Awaiting requested review from j00bar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Voronenko @gregdek
0