Patternfly 5 #4866
Merged
Patternfly 5 #4866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
176b5c6 to
40f6ed3
Compare
7910479 to
d3d1ed8
Compare
4a199cd to
d89b2be
Compare
because codemod is using an old parser, cant handle ||= or import { type x }
…tedPath --fix and `npm run prettier`
…de-editor@latest @patternfly/react-core@latest @patternfly/react-table@latest @redhat-cloud-services/frontend-components@latest
~/ts-imports/splitImports.js src/**/*.{ts,tsx} | grep Props\ } | cut -d: -f1,2 | sed 's/^\(.*\):\(.*\)$/sed -i -e '\''\2s\/\\w\\+Props\/type \&\/'\'' \1/' | sh
<
8000
a title="role-namespace-info" data-pjax="true" class="Link--secondary markdown-title" href="/ansible/ansible-hub-ui/pull/4866/commits/1bb07e96f31b45676e95bb479507a773f358a311">role-namespace-info
to disambiguate with patternfly HelperText
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Mar 19, 2024
After ansible#4866 looks like removing the singleton setting for react-router-dom was premature, putting back, with an explicit version which is now required No-Issue
Merged
himdel
added a commit
that referenced
this pull request
Mar 19, 2024
* fixup insights build After #4866 looks like removing the singleton setting for react-router-dom was premature, putting back, with an explicit version which is now required No-Issue * oh, the version field was just renamed, still accepts * * update webpack check to cope with new fec format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pendin
2BA8
g reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives: #2095, #4141
Follows: #4863, #4864, #4867
Issue: AAH-3040
Update to Patternfly 5
pf-l-andpf-c-css classnames topf-v5-*pf-v5-*eventas the first argPageHeadertoMastheadFormFieldHelperto replace removedFormGrouphelperTextpropCHANGESFor post-merge
For separate PRs:
@patternfly/react-core/deprecated- Select, Dropdown, WizardDropdown DropdownItem DropdownPosition DropdownSeparator DropdownToggle DropdownToggleCheckbox KebabToggle Select SelectGroup SelectOption SelectVariant Wizard as PFWizard WizardStepHubFormGroup? or direct toDataForm?PageSection