8000 pf5 - update deprecated imports by himdel · Pull Request #4935 · ansible/ansible-hub-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pf5 - update deprecated imports #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers 8000 and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pf5 - update deprecated imports #4935

wants to merge 1 commit into from

Conversation

himdel
Copy link
Collaborator
@himdel himdel commented Mar 19, 2024 •
edited
Loading

Follows #4866

replace @patternfly/react-core/deprecated imports:

TODO Also deal with l10n for any new components.

// @patternfly/react-core/deprecated

Select
  clearSelectionsAriaLabel={t`Clear all`}
  createText={t`Create`}
  favoritesLabel={t`Favorites`}
  noResultsFoundText={t`No results found`}
  removeSelectionAriaLabel={t`Remove`}
  toggleAriaLabel={t`Options menu`}

(later TODOs?)
test dark mode, https://www.patternfly.org/design-foundations/colors
revisit the whole form/formhelpertext/helpertext thing into a HubFormGroup? or direct to DataForm?
use patternfly component groups instead of custom impls
consistently use PageSection

@github-actions github-actions bot added the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Mar 19, 2024
@himdel himdel removed the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Mar 19, 2024
This was referenced Mar 27, 2024
Merged
Closed
@himdel himdel closed this Jun 12, 2024
@himdel himdel deleted the pf5-deprecated branch June 12, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@himdel
0