feat: Use pyproject.toml instead of setup.cfg + pinned dependencies + ruff as linter. #1325
Conversation
8be2b6c to
2010c35
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## devel #1325 +/- ##
==========================================
+ Coverage 43.72% 44.50% +0.78%
==========================================
Files 57 60 +3
Lines 9782 10423 +641
==========================================
+ Hits 4277 4639 +362
- Misses 5193 5469 +276
- Partials 312 315 +3
... and 6 files with indirect coverage changes
🚀 New features to boost your workflow:
|
2010c35 to
42502e2
Compare
42502e2 to
04dead9
Compare
5b9e5f7 to
2f55ce6
Compare
receptorctl/pyproject.toml
Outdated
| "python-dateutil==2.9.0", | ||
| "click==8.1.8", | ||
| "PyYAML==6.0.2", |
There was a problem hiding this comment.
Pin to exact versions will cause conflicts, especially because the same receptor version is used in multiple AAP releases with different dependent rpm versions. Can you set lower and/or upper version constraint instead?
There was a problem hiding this comment.
You are right. Testing this with different versions is a bit challenging though. Will update the PR once I manage to do that.
There was a problem hiding this comment.
Adding approval, knowing that this won't be merged until the comment by @simaishi about version pinning is resolved.
2f55ce6 to
793b8ce
Compare
793b8ce to
f8988c4
Compare
|
AAP-45792
Changes:
optional-dependencies) dependencies as they will be constrained by project dependencies as per PEP 633.VERSIONand instead use standard tooling. For linting or test report, default to afallback_version. When building, useSETUPTOOLS_SCM_PRETEND_VERSIONvariables. DocumentationAll nox sessions are kept, so CI does not need to be changed.