8000 Sync 1.6 with main by christyjacob4 · Pull Request #8529 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sync 1.6 with main #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 114 commits into from
Aug 13, 2024
Merged

Sync 1.6 with main #8529

merged 114 commits into from
Aug 13, 2024

Conversation

christyjacob4
Copy link
Member

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

stnguyen90 and others added 20 commits August 7, 2024 22:17
fix: Moving migration to be inside coroutine completely
Bump executor version from 0.5.5 to 0.5.7
The iterator was in the loop so it was always reset to null and the
same data set to be scanned.

For cases where this happened, the iterator was not empty, but the keys
returned from the scan was empty. According to [redis](https://redis.io/docs/latest/commands/scan/#number-of-elements-returned-at-every-scan-call),
this is expected behavior.

> SCAN family functions do not guarantee that the number of elements returned per call are in a given range. The commands are also allowed to return zero elements, and the client should not consider the iteration complete as long as the returned cursor is not zero.

As such, we must make sure we're using the new iterator returned to
continue scanning the keys.
Fix migration stuck at "Starting Data Migration [...]"
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
curl 8.5.0-r0 CVE-2024-2398 HIGH
libcurl 8.5.0-r0 CVE-2024-2398 HIGH
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v25.0.1+incompatible CVE-2024-41110 CRITICAL
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 CVE-2023-47108 HIGH
stdlib 1.21.6 CVE-2024-24790 CRITICAL
stdlib 1.21.6 CVE-2023-45288 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Aug 13, 2024

✨ Benchmark results

  • Requests per second: 1,541
  • Requests with 200 status code: 277,459
  • P99 latency: 0.0843868

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,541 2,012
200 277,459 362,258
P99 0.0843868 0.076005299

@christyjacob4 christyjacob4 marked this pull request as ready for review August 13, 2024 16:00
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
curl 8.5.0-r0 CVE-2024-2398 HIGH
libcurl 8.5.0-r0 CVE-2024-2398 HIGH
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v25.0.1+incompatible CVE-2024-41110 CRITICAL
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 CVE-2023-47108 HIGH
stdlib 1.21.6 CVE-2024-24790 CRITICAL
stdlib 1.21.6 CVE-2023-45288 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@christyjacob4 christyjacob4 changed the title Sync 1.6 main Sync 1.6 with main Aug 13, 2024
@christyjacob4 christyjacob4 merged commit bf63ab8 into 1.6.x Aug 13, 2024
24 of 25 checks passed
@christyjacob4 christyjacob4 deleted the sync-1.6-main branch August 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0