8000 feat: Introduce capabilities package by simar7 · Pull Request #1256 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Introduce capabilities package #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 14, 2022
Merged

feat: Introduce capabilities package #1256

merged 10 commits into from
Jan 14, 2022

Conversation

simar7
Copy link
Member
@simar7 simar7 commented Dec 15, 2021 •
edited by yanivagman
Loading

This PR addresses the need for capabilities to be in its own testable package space.

Close #1254

@simar7
feat: Introduce pkg/capabilities with tests.
18936cf 
Signed-off-by: Simar <simar@linux.com>
@simar7
feat: Unwrap capability initialization from load logic.
47c4bbb 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 self-assigned this Dec 15, 2021
@simar7 simar7 changed the title Capabilities package feat: Introduce capabilities package Dec 15, 2021
@simar7
chore: Deprecate old tests for capabilities.
0b0b3b9 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 mentioned this pull request Dec 15, 2021
Closed
@mtcherni95
Copy link
Contributor

I think we both opened a PR on the same feature :) #1253

@simar7
8000 Copy link
Member Author
simar7 commented Dec 15, 2021

I think we both opened a PR on the same feature :) #1253

I'm fine keeping either one as long as we can reconcile our work together. If you would like to merge yours, please add the tests I've tried to add here.

@mtcherni95
Copy link
Contributor

I think we both opened a PR on the same feature :) #1253

I'm fine keeping either one as long as we can reconcile our work together. If you would like to merge yours, please add the tests I've tried to add here.

Since you already added tests, I'm more than ok to go with yours :)

danielpacak
danielpacak suggested changes Dec 16, 2021
View reviewed changes
mtcherni95
mtcherni95 suggested changes Dec 18, 2021
View reviewed changes
@yanivagman
Copy link
Collaborator

Have you guys seen #1202?
This PR drops capabilities on start, and is related to this change.

@danielpacak
Copy link
Contributor
danielpacak commented Dec 20, 2021 •
edited
Loading

Have you guys seen #1202?
This PR drops capabilities on start, and is related to this change.

Thank you for the heads up @yanivagman. I wasn't aware of the other patch. That's one of the reasons why I'm more and more inclined to Opportunistic Refactoring, aka boy-scout rule, rather than refactoring for refactoring kind of task.

simar7 and others added 5 commits January 4, 2022 17:30
@rafaeldtinoco
Copy link
Contributor

@AlonZivony I think this overlaps to what I suggested to you in your PR #1202 (on selfCapabilities functions).

@rafaeldtinoco rafaeldtinoco mentioned this pull request Jan 5, 2022
Merged
@simar7 simar7 requested a review from danielpacak January 5, 2022 23:14
simar7 and others added 2 commits January 13, 2022 16:22
danielpacak
danielpacak approved these changes Jan 14, 2022
View reviewed changes
danielpacak
danielpacak reviewed Jan 14, 2022
View reviewed changes
mtcherni95
mtcherni95 approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor
@mtcherni95 mtcherni95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielpacak danielpacak merged commit 14832df into aquasecurity:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpacak danielpacak danielpacak approved these changes

@mtcherni95 mtcherni95 mtcherni95 approved these changes

@itaysk itaysk Awaiting requested review from itaysk

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create capabilities package
5 participants
@simar7 @mtcherni95 @yanivagman @danielpacak @rafaeldtinoco
0