creating and using package capabilties #1253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpacak
reviewed
Dec 14, 2021
| @@ -2,6 +2,7 @@ package main | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/aquasecurity/tracee/pkg/capabilities" | |||
There was a problem hiding this comment.
Are you using goimports?
| @@ -88,11 +89,11 @@ func main() { | |||
|
|
|||
| // environment capabilities | |||
|
|
|||
| selfCap, err := getSelfCapabilities() | |||
| selfCap, err := capabilities.SelfCapabilities() | |||
There was a problem hiding this comment.
I'm wondering if we could avoid repetition in package names and exported functions as explained in Effective Go Package Names WDYT?
Suggested change
| selfCap, err := capabilities.SelfCapabilities() | |
| selfCap, err := capabilities.Self() |
| if err != nil { | ||
| return err | ||
| } | ||
| if err = checkRequiredCapabilities(selfCap); err != nil { | ||
| if err = capabilities.CheckRequiredCapabilities(selfCap); err != nil { |
There was a problem hiding this comment.
DITTO
Suggested change
| if err = capabilities.CheckRequiredCapabilities(selfCap); err != nil { | |
| if err = capabilities.CheckRequired(selfCap); err != nil { |
danielpacak
reviewed
Dec 14, 2021
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/syndtr/gocapability/capability" |
There was a problem hiding this comment.
Out of scope of this PR but I was wondering if we are okey with gocapability BSD 2-Clause "Simplified" License. (I assume that the fact it's not very actively maintained is because it is feature complete?)
|
We might be stepping on over on each others feet here #1256 I've restructured the package layout and re-did tests for it. I think we should reconcile our PRs to avoid duplicate work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1254