sequencer: reduce maximum block size to 4MiB #1183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21MiB block size considered harmful. See: cometbft/cometbft#1518 GHSA-hq58-p9mv-338c https://github.com/notional-labs/placid
This is the limit currently set by upstream: cometbft/cometbft#1518
|
We already had updates in flight for what works for Astria: #1193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set genesis params to match new upstream values.
Background
21MiB was the old default set by upstream, 4MiB is the new, safer default after discovering the p2p storms issue. See:
cometbft/cometbft#1518
GHSA-hq58-p9mv-338c
https://github.com/notional-labs/placid
Changes
Testing
Launch a new testnet with the new genesis.json?