Refactor(chart, sequencer): restructure sequencer chart, adjust configs #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actions that have addresses
joroshiba
reviewed
Jun 20, 2024
|
|
||
| ##### additional base config options ##### | ||
|
|
||
| # Path to the JSON file containing the initial validator set and other meta data | ||
| genesis_file = "config/genesis.json" | ||
| genesis_file = "{{ .Values.cometbft.config.genesisFile}}" |
There was a problem hiding this comment.
This one maybe doesn't need to be a value
| @@ -87,7 +87,7 @@ filter_peers = false | |||
| [rpc] | |||
|
|
|||
| # TCP or UNIX socket address for the RPC server to listen on | |||
| laddr = "tcp://0.0.0.0:{{ .Values.ports.cometBFTRPC }}" | |||
| laddr = "tcp://0.0.0.0:{{ .Values.ports.cometbftRpc }}" | |||
There was a problem hiding this comment.
Potentially could allow this to be 127.0.0.1 if we allow rpc to be disabled?
|
|
||
| # Comma separated list of peer IDs to keep private (will not be gossiped to other peers) | ||
| private_peer_ids = "{{ join "," .Values.config.cometBFT.p2p.privatePeers }}" | ||
| private_peer_ids = "{{ join "," .Values.cometbft.config.p2p.privatePeers }}" | ||
|
|
||
| # Toggle to disable guard against peers connecting from the same ip. | ||
| allow_duplicate_ip = false |
There was a problem hiding this comment.
Again should this be configurable?
| @@ -486,4 +486,4 @@ prometheus_listen_addr = ":26660" | |||
| max_open_connections = 3 | |||
|
|
|||
| # Instrumentation namespace | |||
| namespace = "cometbft" | |||
| namespace = "astria_cometbft" | |||
There was a problem hiding this comment.
potentially allow configuration?
| ASTRIA_SEQUENCER_GRPC_ADDR: "0.0.0.0:{{ .Values.ports.sequencerGRPC }}" | ||
| ASTRIA_SEQUENCER_NO_METRICS: "{{ not .Values.config.sequencer.metrics.enabled }}" | ||
| # Socket address for GRPC server | ||
| ASTRIA_SEQUENCER_GRPC_ADDR: "0.0.0.0:{{ .Values.ports.sequencerGRpc }}" |
There was a problem hiding this comment.
nit: I think sequencerGRPC is technically correct here as the protocol is officially gRPC.
I also know that we do Rpc instead of RPC given that I think I prefer sequencerGrpc over serquencerGRpc which just feels off somehow lol.
…aorg/astria into quasystaty1/updated-chart-params
…pdated-chart-params
…pdated-chart-params Merge update evm chart for new prefix field into quasystaty1/updated-chart-params
joroshiba
approved these changes
Jun 27, 2024
Co-authored-by: Jordan Oroshiba <jordan@astria.org>
Co-authored-by: Jordan Oroshiba <jordan@astria.org>
This was referenced Jul 1, 2024
steezeburger
added a commit
that referenced
this pull request
Jul 11, 2024
* main: (27 commits) refactor(sequencer): fix prepare proposal metrics (#1211) refactor(bridge-withdrawer): move generated contract bindings to crate (#1237) fix(sequencer) fix wrong metric and remove unused metric (#1240) feat(sequencer): implement transaction fee query (#1196) chore(cli)!: remove unmaintained rollup subcommand (#1235) release(sequencer): 0.14.1 patch release (#1233) feat(sequencer-utils): generate example genesis state (#1224) feat(sequencer): implement abci query for bridge account info (#1189) feat(charts): bridge-withdrawer, smoke test, various chart improvements (#1141) chore(charts): update for new geth update (#1226) chore(chart)!: dusk-8 chart version updates (#1223) release(conductor): fix conductor release version (#1222) release: dusk-8 versions (#1219) fix(core): revert `From` ed25519_consensus types for crypto mod (#1220) Refactor(chart, sequencer): restructure sequencer chart, adjust configs (#1193) refactor(withdrawer): read from block subscription stream and get events on each block (#1207) feat(core): implement with verification key for address builder and crypto improvements (#1218) feat(proto, sequencer)!: use full IBC ICS20 denoms instead of IDs (#1209) chore(chart): update evm chart for new prefix field (#1214) chore: bump penumbra deps (#1216) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request aims to enhance the consistency of our Helm chart and improve the definition of values and their associated services.
The primary changes include:
Background
The helm charts used for deploying the Astria stack lack clarity for
value.yamldefinition and structureChanges
values.yamldistinguishing between their values.cometBFT -> cometbftTesting
Tested locally both with a single sequencer node and multi-nodes