Drop testnet3 #31974
Drop testnet3 #31974
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31974. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
I've said it elsewhere, but I think it deserves a quite long deprecation cycle, along with some data gathering. We don't want services not upgrading for fixes because their test environment would break. e.g., what exchanges with testnet environments have adopted testnet4 (or signet), much less would be ok with removing testnet3? Does btcd support it? LND? Eclaire? CLN? etc. Lots of work to be done here imo. |
|
I opened a separate RFC to discuss when to drop testnet3: #31975 I can rebase this for a while if we decide v30 is too early. |
|
Concept ACK |
|
I split 5d6aa13 into smaller commits. If we decide to punt this until after v30 then I'll PR some of these separately. E.g. there's some tests that can use testnet4 instead of testnet3 and perhaps we can drop GUI support earlier. |
|
Will rebase after #31649 is rebased. |
|
Rebased after #32096. |
Except for the deprecation warning in feature_config_args.py. This test now writes its own config file, which was previously done by test_acceptstalefeeestimates_arg_support. The deprecation warning test will be removed in a later commit.
Abort node startup and inform user they should use -testnet4. Modify the deprecation message test to cover this. Remove testnet3 references from bitcoin-cli documentation and bash helper.
Also use "test network" instead of "testnet" where appropriate (e.g. because it also applies to signet).
This drops the chain parameters and ChainType::TESTNET.
|
Trivial rebase after #24450. |
Testnet3 was deprecated in v28 with the introduction of testnet4. It will be dropped in v30 or later, please discuss in #31975.
There is no more
[test]network section. The user is expected to set testnet4 explicitly, which should make future rotation of testnets easier.If a
[test]or[testnet3]section is present inbitcoin.confa warning is issued:Starting with
-testnet3will be greeted with an error message:This also prevents a fallback to mainnet.
Starting with
-testwas already not possible with testnet3.Review hints:
Guix hashes: