docs: adds correct updated documentation links #32699
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32699. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. LLM Linter (✨ experimental)Possible typos and grammar issues:
drahtbot_id_4_m |
it does, still trying to get a workaround that automatically updates it |
i have update it so it fetches the docs based on build version |
src/wallet/init.cpp
Outdated
| @@ -66,7 +67,7 @@ void WalletInit::AddWalletOptions(ArgsManager& argsman) const | |||
| argsman.AddArg("-paytxfee=<amt>", strprintf("(DEPRECATED) Fee rate (in %s/kvB) to add to transactions you send (default: %s)", | |||
| CURRENCY_UNIT, FormatMoney(CFeeRate{DEFAULT_PAY_TX_FEE}.GetFeePerK())), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET); | |||
| #ifdef ENABLE_EXTERNAL_SIGNER | |||
| argsman.AddArg("-signer=<cmd>", "External signing tool, see doc/external-signer.md", ArgsManager::ALLOW_ANY, OptionsCategory::WALLET); | |||
| argsman.AddArg("-signer=<cmd>", strprintf("External signing tool, see https://github.com/bitcoin/bitcoin/blob/v%d.%d/doc/external-signer.md", CLIENT_VERSION_MAJOR, CLIENT_VERSION_MINOR), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET); | |||
There was a problem hiding this comment.
Running on master branch, I get:
-signer=<cmd>
External signing tool, see
https://github.com/bitcoin/bitcoin/blob/v29.99/doc/external-signer.md...which is incorrect since there is no v29.99.
There was a problem hiding this comment.
this could be because you are on developement version. Let me try set it to the latest stable version
|
You can squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits. |
thankyou for this |
df115d0 to
40c2323
Compare
There was a problem hiding this comment.
I checked out v29.0 with the changes, I got:
-cjdnsreachable If set, then this host is configured for CJDNS (connecting to fc00::/8 addresses would lead us to the CJDNS network, see https://github.com/bitcoin/bitcoin/blob/v29.0/doc/cjdns.md) (default: 0)
which links correctly, the function GetDocumentationUrl looks good to me
|
Thankyou for the feedback
…On Mon, 16 Jun 2025 at 15:09, musaHaruna ***@***.***> wrote:
***@***.**** commented on this pull request.
I checked out v29.0 with the changes, I got:
-cjdnsreachable If set, then this host is configured for CJDNS (connecting
to fc00::/8 addresses would lead us to the CJDNS network, see
https://github.com/bitcoin/bitcoin/blob/v29.0/doc/cjdns.md) (default: 0)
which links correctly, the function GetDocumentationUrl looks good to me
—
Reply to this email directly, view it on GitHub
<#32699 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZVGWLGZSNRGKGVIZRYRJGL3D2XYVAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZRHA4DANJYHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| @@ -157,7 +157,7 @@ static constexpr bool DEFAULT_STOPAFTERBLOCKIMPORT{false}; | |||
| #endif | |||
|
|
|||
| static constexpr int MIN_CORE_FDS = MIN_LEVELDB_FDS + NUM_FDS_MESSAGE_CAPTURE; | |||
| static const char* DEFAULT_ASMAP_FILENAME="ip_asn.map"; | |||
| static const char* DEFAULT_ASMAP_FILENAME = "ip_asn.map"; | |||
There was a problem hiding this comment.
Thanks for the PR! I notice there are some whitespace changes that appear unrelated to the main goal of fixing documentation references.
While these changes don't affect functionality, it would be helpful to keep the diff focused on the actual documentation URL changes. This makes the PR easier to review and reduces the risk of merge conflicts.
Could you please remove these unrelated whitespace changes? This will make the PR's intent clearer and follow the principle of keeping changes minimal and focused.
The core changes to fix the documentation references look good.
|
Thank you, I will do just that
…On Mon, 16 Jun 2025 at 18:12, Winnie Gitau ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/init.cpp
<#32699 (comment)>:
> @@ -157,7 +157,7 @@ static constexpr bool DEFAULT_STOPAFTERBLOCKIMPORT{false};
#endif
static constexpr int MIN_CORE_FDS = MIN_LEVELDB_FDS + NUM_FDS_MESSAGE_CAPTURE;
-static const char* DEFAULT_ASMAP_FILENAME="ip_asn.map";
+static const char* DEFAULT_ASMAP_FILENAME = "ip_asn.map";
Thanks for the PR! I notice there are some whitespace changes that appear
unrelated to the main goal of fixing documentation references.
While these changes don't affect functionality, it would be helpful to
keep the diff focused on the actual documentation URL changes. This makes
the PR easier to review and reduces the risk of merge conflicts.
Could you please remove these unrelated whitespace changes? This will make
the PR's intent clearer and follow the principle of keeping changes minimal
and focused.
The core changes to fix the documentation references look good.
—
Reply to this email directly, view it on GitHub
<#32699 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZVGWLD5HTPO47YKQ2QXSG33D3NEPAVCNFSM6AAAAAB6ZXKXIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZSGU2DSMBTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Added correct links to the docs in place of the missing docs' paths.
Fixes #32565