wallet: Remove ISMINE_WATCHONLY and watchonly from RPCs #32618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32618. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. LLM Linter (✨ experimental)Possible typos and grammar issues:
drahtbot_id_4_m |
9d046bb to
ae4f681
Compare
This was referenced May 26, 2025
ae4f681 to
9e5f934
Compare
f444eda to
69c6a2a
Compare
rkrux
reviewed
Jun 12, 2025
ee431e4 to
2aa5c97
Compare
|
Ready for review |
Test that when a watchonly wallet and the wallet with private keys fund the same tx, the watchonly wallet should use a higher fee since it should be estimating the size to be larger as it assumes the signer cannot grind the R value.
Descriptor wallets do not have mixed mine and watchonly, so there is no need to report a watchonly balance.
Descriptor wallets don't have a conception of watchonly within a wallet, so remove all of these options and results from the RPCs
Descriptor wallets do not have a concept of watchonly within a wallet, so remove the watchonly option from coin control.
ISMINE_WATCH_ONLY has been removed from all places it was being used, and migration does not need ISMINE_WATCH_ONLY, so remove the enum.
2aa5c97 to
003a3cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptor wallets do not use the watchonly behavior as it is not possible to mix watchonly and non-watchonly in a descriptor wallet. With legacy wallets now removed, all of the watchonly handling and reporting code is no longer needed. This PR removes watchonly options and results from the RPCs and the handling of watchonly things from the wallet's internals.
With all of the watchonly things removed, ISMINE_WATCH_ONLY is removed as well.
Split from #32523
Depends on #32594 for tests that are easier to read