8000 fuzz: wallet: remove `FundTx` from `FuzzedWallet` by brunoerg · Pull Request #32772 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fuzz: wallet: remove FundTx from FuzzedWallet #32772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

brunoerg
Copy link
Contributor

FundTx was used by the wallet_notifications target which we recently removed. So it's now unused and can be removed.

@DrahtBot DrahtBot added the Tests label Jun 18, 2025
@DrahtBot
Copy link
Contributor
DrahtBot commented Jun 18, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32772.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, dergoegge, kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #32750 (refactor: CFeeRate encapsulates FeeFrac internally by polespinasa)
  • #32618 (wallet: Remove ISMINE_WATCHONLY and watchonly from RPCs by achow101)
  • #32523 (wallet: Remove watchonly behavior and isminetypes by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@brunoerg
Copy link
Contributor Author

cc @maflcko

@maflcko
Copy link
Member
maflcko commented Jun 18, 2025

lgtm ACK cd1ae1b

Copy link
Member
@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK cd1ae1b

@kevkevinpal
Copy link
Contributor

ACK cd1ae1b

makes sense to remove dead code

@fanquake fanquake merged commit 154b98a into bitcoin:master Jun 19, 2025
19 checks passed
@brunoerg brunoerg deleted the 2025-06-fuzz-delete-fundtx branch June 19, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0