8000 Innovation/archive/server by Patrick-Pimentel-Bitwarden · Pull Request #5672 · bitwarden/server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Innovation/archive/server #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Patrick-Pimentel-Bitwarden
Copy link
Contributor

🎟️ Tracking

Innovation Sprint Server Work

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

gbubemismith and others added 5 commits March 12, 2025 11:11
…Items (#5489)

* Added the ArchivedDate to cipher entity and response model

* Created migration scripts for sqlserver and ef core migration to add the ArchivedDate column

* Fixed linting

* Fixed syntax

* Manually refresh the UserCipherDetailsView
* feat(innovation-archive): Controller Work - Added bulk endpoints for archive and feature flagged them.

* feat(innovation-archive): Controller Work - Added in archive unarchive stored procedure.

* test(innovation-archive): Controller Work - Got test logic working.

---------

Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
Copy link
Contributor

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found Info
Innovation Sprint - Archive Items pm-19148-innovation-archive

Copy link

Copy link
codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 41.79894% with 110 lines in your changes missing coverage. Please review.

Project coverage is 47.53%. Comparing base (63f5811) to head (8ee386f).

Files with missing lines Patch % Lines
...tyFramework/Vault/Repositories/CipherRepository.cs 0.00% 46 Missing ⚠️
src/Api/Vault/Controllers/CiphersController.cs 14.28% 30 Missing ⚠️
...ture.Dapper/Vault/Repositories/CipherRepository.cs 0.00% 19 Missing ⚠️
...re/Vault/Services/Implementations/CipherService.cs 0.00% 4 Missing and 1 partial ⚠️
src/Core/Vault/Commands/UnarchiveCiphersCommand.cs 88.23% 2 Missing and 2 partials ⚠️
src/Core/Vault/Commands/ArchiveCiphersCommand.cs 91.17% 2 Missing and 1 partial ⚠️
src/Api/Vault/Models/Request/CipherRequestModel.cs 50.00% 2 Missing ⚠️
...k/Vault/Repositories/Queries/CipherDetailsQuery.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5672      +/-   ##
==========================================
- Coverage   47.54%   47.53%   -0.02%     
==========================================
  Files        1669     1671       +2     
  Lines       75348    75522     +174     
  Branches     6760     6774      +14     
==========================================
+ Hits        35826    35900      +74     
- Misses      38063    38159      +96     
- Partials     1459     1463       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor
github-actions bot commented Apr 18, 2025

Logo
Checkmarx One – Scan Summary & Details77d5313e-ff96-4d83-a3c6-2b51604edd85

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
detailsMethod Put at line 164 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter v...
ID: yt2PajNvte2IY7Xe%2FRtOPf8qKlo%3D
Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/Layouts/Full.html.hbs: 164
detailsA Content Security Policy is not explicitly defined within the web-application.
ID: iDkz8rv3w1QoR%2BKANf%2FBdTS52Xc%3D
Attack Vector

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0