8000 feat: import command by jhoward-lm · Pull Request #113 · bomctl/bomctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: import command #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2024
Merged

feat: import command #113

merged 5 commits into from
Aug 7, 2024

Conversation

jhoward-lm
Copy link
Contributor

Import command

Description

Add import sub command that stores SBOM data from stdin or a file on the local filesystem.

Import SBOM file(s) from stdin or local filesystem

Usage:
  bomctl import [flags] { - | FILE...}

Flags:
  -h, --help   help for import

Global Flags:
      --cache-dir string   cache directory [defaults:
                                Unix:    $HOME/.cache/bomctl
                                Darwin:  $HOME/Library/Caches/bomctl
                                Windows: %LocalAppData%\bomctl]
      --config string      config file [defaults:
                                Unix:    $HOME/.config/bomctl/bomctl.yaml
                                Darwin:  $HOME/Library/Application Support/bomctl/bomctl.yml
                                Windows: %AppData%\bomctl\bomctl.yml]
  -v, --verbose count      Enable debug output

Miscellaneous

  • Refactor to extract CacheDir, ConfigFile, Debug, and Logger options shared by all commands' options types into base Options type
  • Implement functional options pattern and builder patterns for setting options for commands and backend

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm jhoward-lm self-assigned this Aug 1, 2024
@jhoward-lm jhoward-lm requested a review from a team as a code owner August 1, 2024 18:11
@idunbarh
Copy link
Member
idunbarh commented Aug 1, 2024

What are your thoughts on docs? I'm happy to help work on them separately.

idunbarh
idunbarh approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member
@idunbarh idunbarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent about 10 minutes playing with this new command. Looks good!

@jhoward-lm
refactor: export command supported formats
fe69830 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
refactor: remove text encoding unsupported by protobom
812fbd3 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm
feat: import subcommand
bec4fc8 
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm merged commit 381c9bf into main Aug 7, 2024
8 checks passed
@jhoward-lm jhoward-lm deleted the import-command branch August 7, 2024 14:03
@pkwiatkowski1 pkwiatkowski1 mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashearin ashearin ashearin approved these changes

@idunbarh idunbarh idunbarh approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@houdini91 houdini91 Awaiting requested review from houdini91

@mfrystacky mfrystacky Awaiting requested review from mfrystacky

Assignees

@jhoward-lm jhoward-lm

Labels
None yet
Projects
bomctl
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhoward-lm @idunbarh @ashearin
0