8000 Update logging verbosity for visualization code by akshay-krishnan · Pull Request #835 · borglab/gtsfm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update logging verbosity for visualization code #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update logging verbosity for visualization code #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,7 @@ cache/

# Dev notebooks
notebooks/


results/**
result_metrics/**
2 changes: 1 addition & 1 deletion gtsfm/loader/loader_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def get_image(self, index: int) -> Image:
target_h,
target_w,
) = img_utils.get_downsampling_factor_per_axis(img_full_res.height, img_full_res.width, self._max_resolution)
logger.info(
logger.debug(
"Image %d resized from (H,W)=(%d,%d) -> (%d,%d)",
index,
img_full_res.height,
Expand Down
4 changes: 2 additions & 2 deletions gtsfm/scene_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@
logger = logger_utils.get_logger()

mpl_logger = logging.getLogger("matplotlib")
mpl_logger.setLevel(logging.WARNING)
mpl_logger.setLevel(logging.ERROR)

pil_logger = logging.getLogger("PIL")
pil_logger.setLevel(logging.INFO)
pil_logger.setLevel(logging.ERROR)


class SceneOptimizer:
Expand Down
41 changes: 22 additions & 19 deletions gtsfm/two_view_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Authors: Ayush Baid, John Lambert
"""

import dataclasses
import logging
import timeit
Expand Down Expand Up @@ -30,10 +31,10 @@
logger = logger_utils.get_logger()

mpl_logger = logging.getLogger("matplotlib")
mpl_logger.setLevel(logging.WARNING)
mpl_logger.setLevel(logging.ERROR)

pil_logger = logging.getLogger("PIL")
pil_logger.setLevel(logging.INFO)
pil_logger.setLevel(logging.ERROR)

PRE_BA_REPORT_TAG = "PRE_BA_2VIEW_REPORT"
POST_BA_REPORT_TAG = "POST_BA_2VIEW_REPORT"
Expand Down Expand Up @@ -203,7 +204,7 @@ def bundle_adjust(
)
if ba_output is None:
# Indeterminate linear system was met.
return None, None, np.zeros((0,2), dtype=np.int32)
return None, None, np.zeros((0, 2), dtype=np.int32)

# Unpack results.
valid_corr_idxs = verified_corr_idxs[triangulated_indices][valid_mask]
Expand Down Expand Up @@ -625,24 +626,26 @@ def round_fn(x: Optional[float]) -> Optional[float]:
"i2_filename": images[i2].file_name,
"rotation_angular_error": round_fn(report.R_error_deg),
"translation_angular_error": round_fn(report.U_error_deg),
"num_inliers_gt_model": int(report.num_inliers_gt_model)
if report.num_inliers_gt_model is not None
else None,
"num_inliers_gt_model": (
int(report.num_inliers_gt_model) if report.num_inliers_gt_model is not None else None
),
"inlier_ratio_gt_model": round_fn(report.inlier_ratio_gt_model),
"inlier_avg_reproj_error_gt_model": round_fn(
np.nanmean(report.reproj_error_gt_model[report.v_corr_idxs_inlier_mask_gt])
)
if report.reproj_error_gt_model is not None and report.v_corr_idxs_inlier_mask_gt is not None
else None,
"outlier_avg_reproj_error_gt_model": round_fn(
np.nanmean(report.reproj_error_gt_model[np.logical_not(report.v_corr_idxs_inlier_mask_gt)])
)
if report.reproj_error_gt_model is not None and report.v_corr_idxs_inlier_mask_gt is not None
else None,
"inlier_avg_reproj_error_gt_model": (
round_fn(np.nanmean(report.reproj_error_gt_model[report.v_corr_idxs_inlier_mask_gt]))
if report.reproj_error_gt_model is not None and report.v_corr_idxs_inlier_mask_gt is not None
else None
),
"outlier_avg_reproj_error_gt_model": (
round_fn(
np.nanmean(report.reproj_error_gt_model[np.logical_not(report.v_corr_idxs_inlier_mask_gt)])
)
if report.reproj_error_gt_model is not None and report.v_corr_idxs_inlier_mask_gt is not None
else None
),
"inlier_ratio_est_model": round_fn(report.inlier_ratio_est_model),
"num_inliers_est_model": int(report.num_inliers_est_model)
if report.num_inliers_est_model is not None
else None,
"num_inliers_est_model": (
int(report.num_inliers_est_model) if report.num_inliers_est_model is not None else None
),
}
)
return metrics_list
5 changes: 3 additions & 2 deletions gtsfm/two_view_estimator_cacher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Authors: Ayush Baid
"""

import logging
from pathlib import Path
from typing import Any, List, Optional
Expand All @@ -27,10 +28,10 @@
logger = logger_utils.get_logger()

mpl_logger = logging.getLogger("matplotlib")
mpl_logger.setLevel(logging.WARNING)
mpl_logger.setLevel(logging.ERROR)

pil_logger = logging.getLogger("PIL")
pil_logger.setLevel(logging.INFO)
pil_logger.setLevel(logging.ERROR)


class TwoViewEstimatorCacher(TwoViewEstimator):
Expand Down
1 change: 1 addition & 0 deletions gtsfm/utils/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Authors: Ayush Baid, John Lambert.
"""

import logging
import sys
from logging import Logger
Expand Down
Loading
0