(bug) (types) Workaround for mas account failing on macOS >= 12... now also include macOS 13 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
| 1 Warning | |
|---|---|
| Are you sure we don't need to add/update tests? |
Generated by 🚫 Danger
Generated by 🚫 Danger |
…w also include macOS 13 Addition to borksh#43 Very obviously super hacky... but it's a quick and dirty GOOD ENOUGH for now...
2b50915 to
7970850
Compare
There was a problem hiding this comment.
| ✅ Good on 'ya. | |
|---|---|
| ✅ |
Generated by 🚫 Danger
|
Hah. I'll take it. Let me fix the Ubuntu test workflow and then I'll approve now that Danger is happy. |
|
|
|
Sure thing Edit: neat Edit 2: 2 fast 4 u ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #43
Very obviously super hacky... but it's a quick and dirty GOOD ENOUGH for now...
We experimented with Greater Than Or Equal To stuff in the original PR, but never got it working.
May experiment further at some point... especially as mas-cli/mas#417 appears to be going nowhere fast