8000 (bug) (types) Workaround for mas account failing on macOS >= 12... now also include macOS 13 by lucymhdavies · Pull Request #48 · borksh/bork · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(bug) (types) Workaround for mas account failing on macOS >= 12... now also include macOS 13 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2023
Merged

(bug) (types) Workaround for mas account failing on macOS >= 12... now also include macOS 13 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7970850
(bug) (types) Workaround for mas account failing on macOS >= 12... no…
lucymhdavies Jan 24, 2023
0c61e06
Merge remote-tracking branch 'origin/main' into macos-22
lucymhdavies Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
8000
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/type-mas.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ setup () {
[ "$status" -eq $STATUS_OK ]
}

@test "mas status: does not return FAILED_PRECONDITION when mas account fails on macOS >= 13" {
respond_to "mas account" "return 1"
respond_to "uname -r" "echo 22.2.0"
run mas status 497799835 Xcode
[ "$status" -eq $STATUS_OK ]
}

@test "mas status: returns MISSING when app not installed" {
run mas status 477670270 2Do
[ "$status" -eq $STATUS_MISSING ]
Expand Down
4 changes: 3 additions & 1 deletion types/mas.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ case $action in
# https://github.com/borksh/bork/issues/42
if [ "$?" -gt 0 ]; then
release=$(get_baking_platform_release)
str_matches "$release" "^21\." || return $STATUS_FAILED_PRECONDITION
str_matches "$release" "^21\." || \
str_matches "$release" "^22\." || \
return $STATUS_FAILED_PRECONDITION
fi
bake mas list | grep -E "^$appid" > /dev/null
[ "$?" -gt 0 ] && return $STATUS_MISSING
Expand Down
0