enhancement: Lazy rule table #2460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a single rule table implementation which is empty on start and lazily loads required policies as they're queried. Enables this rule table for all store types. Also solves some other issues: * Makes query planner empty-case output consistent * Fixes E2E tests Signed-off-by: Sam Lock <sam@swlock.co.uk>
Signed-off-by: Sam Lock <sam@swlock.co.uk>
27fa194 to
f4c5002
Compare
Signed-off-by: Sam Lock <sam@swlock.co.uk>
|
I think it's prudent to add some tests cases for store updates (particularly WRT the various rule table caches), so I'll put this PR into |
8000
charithe
reviewed
Jan 28, 2025
Signed-off-by: Sam Lock <sam@swlock.co.uk>
Signed-off-by: Sam Lock <sam@swlock.co.uk>
Signed-off-by: Sam Lock <sam@swlock.co.uk>
Signed-off-by: Sam Lock <sam@swlock.co.uk>
charithe
approved these changes
Jan 30, 2025
Sambigeara
added a commit
that referenced
this pull request
Jan 30, 2025
This was supposed to be part of the [larger PR](#2460) but I forgot to push it 🙃. Signed-off-by: Sam Lock <sam@swlock.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a single rule table implementation which is empty on start and lazily loads required policies as they're queried. Enables this rule table for all store types.
Also solves some other issues:
scopePermissions: *REQUIRES_PARENTAL_CONSENTfall through behaviour