8000 Enable multipart files to support additional headers by Riven-Spell · Pull Request #1263 · cfug/dio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable multipart files to support additional headers #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2021
Merged

Enable multipart files to support additional headers #1263

merged 3 commits into from
Oct 20, 2021

Conversation

Riven-Spell
Copy link
Contributor

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass

Pull Request Description

Enables adding additional headers (outside Content-Type) to files in multipart requests (akin to Golang's multipart support)

jgoyvaerts
jgoyvaerts suggested changes Sep 1, 2021
View reviewed changes
Copy link
Contributor
@jgoyvaerts jgoyvaerts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this repo doesn't seem to be maintained anymore but I'd love to merge your PR into our fork, (dio_http)[https://github.com/dart-tools/dio_http] .

Just added 2 small change requests

Edit: Also can you add the test commit to your main commit so you only have one commit? thanks

@seunghwanly
Copy link
Contributor

Unfortunately this repo doesn't seem to be maintained anymore but I'd love to merge your PR into our fork, (dio_http)[https://github.com/dart-tools/dio_http] .

Just added 2 small change requests

Edit: Also can you add the test commit to your main commit so you only have one commit? thanks

Hi, I faced the issue with the Interceptor while requesting APIs.

I hope to see if your package dio_http does catch the Interceptor issue with onRequest and onError callback functions.

I just solved it by using the http package to catch the issue that Interceptor does not catch 401 error with the onError function. And I think the way I did is not the right answer... it occurs too many callback functions..😭

@jgoyvaerts
Copy link
Contributor

@seunghwanly can you create an issue on https://github.com/dart-tools/dio_http with a code sample of what is not working with the interceptor?

@seunghwanly
Copy link
Contributor

@seunghwanly can you create an issue on https://github.com/dart-tools/dio_http with a code sample of what is not working with the interceptor?

I have adjusted dio_http and found it worked well.. thank you very much!! 😭
Would you mind what was the issue with the interceptor in dio package?? What was the problem..?

@Riven-Spell
Copy link
Contributor Author

Edit: Also can you add the test commit to your main commit so you only have one commit? thanks

If you choose to merge, a squash n merge will do exactly that. That said, I have squashed under the dart-tools-squash branch on my PR, if you want to use that.

@wendux wendux merged commit 4ce282b into cfug:master Oct 20, 2021
wendux added a commit that referenced this pull request Oct 23, 2021
@wendux
# 4.0.1
71b3898 
- merge pr #1177 #1196 #1205 #1224 #1225 #1227 #1256 #1263 #1291
- fix #1257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoyvaerts jgoyvaerts jgoyvaerts requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Riven-Spell @seunghwanly @jgoyvaerts @wendux
0