8000 fix queryParameter unexpectedly overridden by BaseOption by narumi147 · Pull Request #1205 · cfug/dio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix queryParameter unexpectedly overridden by BaseOption #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix queryParameter unexpectedly overridden by BaseOption #1205

merged 1 commit into from
Oct 20, 2021

Conversation

narumi147
Copy link
Contributor

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass

This merge request fixes / refers to the following issues:

Pull Request Description

BaseOptions.queryParameters should be overridden by passed queryParameters.

harsimranmaan
harsimranmaan approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor
@harsimranmaan harsimranmaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a potential backwards breaking bug fix. lgtm

@stale
Copy link
stale bot commented Sep 7, 2021

This pull request has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.
If this is still applicable, please make sure it is up to date and if so,
add a comment that this is still an issue to keep it open.
Thank you for your contributions.

@stale stale bot added the stale label Sep 7, 2021
@wendux wendux merged commit 6cff24c into cfug:master Oct 20, 2021
wendux added a commit that referenced this pull request Oct 23, 2021
@wendux
# 4.0.1
71b3898 
- merge pr #1177 #1196 #1205 #1224 #1225 #1227 #1256 #1263 #1291
- fix #1257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsimranmaan harsimranmaan harsimranmaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narumi147 @harsimranmaan @wendux
0