8000 CI: l4lb allow extra opts by tommyp1ckles · Pull Request #34813 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI: l4lb allow extra opts #34813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

CI: l4lb allow extra opts #34813

merged 1 commit into from
Sep 11, 2024

Conversation

tommyp1ckles
Copy link
Contributor
@tommyp1ckles tommyp1ckles commented Sep 10, 2024 •
edited
Loading

Similar to recent changes to ci-{runtime,gingko,ext-workloads}, this allows the CILIUM_RUNTIME_EXTRA_ARGS to be propagated when installing Cilium for l4lb testing.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 10, 2024
@tommyp1ckles tommyp1ckles changed the title Pr/tp/l4lb allow extra opts [WIP] 4lb allow extra opts Sep 10, 2024
@tommyp1ckles
Copy link
Contributor Author

/ci-l4lb

@tommyp1ckles
.github: l4lb: add option to pass extra args to cilium in CI.
572cb08 
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/l4lb-allow-extra-opts branch from 7c36cbb to 572cb08 Compare September 10, 2024 21:14
@tommyp1ckles
Copy link
Contributor Author

/ci-l4lb

@tommyp1ckles tommyp1ckles changed the title [WIP] 4lb allow extra opts CI: l4lb allow extra opts Sep 10, 2024
@tommyp1ckles tommyp1ckles added the release-note/ci This PR makes changes to the CI. label Sep 10, 2024
@tommyp1ckles tommyp1ckles marked this pull request as ready for review September 10, 2024 21:15
@tommyp1ckles tommyp1ckles requested review from a team as code owners September 10, 2024 21:15
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 10, 2024
@tommyp1ckles tommyp1ckles requested review from nebril and aanm September 10, 2024 21:15
@aanm aanm enabled auto-merge September 11, 2024 07:55
@aanm
Copy link
Member
aanm commented Sep 11, 2024

/test

@aanm aanm added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit fa8b27f Sep 11, 2024
306 of 307 checks passed
@aanm aanm deleted the pr/tp/l4lb-allow-extra-opts branch September 11, 2024 16:16
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommyp1ckles @aanm @nebril @ysksuzuki
0