8000 devices controller: spell out list of required netlink families by julianwiedmann · Pull Request #37123 · cilium/cilium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

devices controller: spell out list of required netlink families #37123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

devices controller: spell out list of required netlink families #37123

merged 1 commit into from
Jan 23, 2025

Conversation

julianwiedmann
Copy link
Member

Spell out the list of netlink families that we use. Otherwise the netlink library will pull in a default list (SupportedNlFamilies) which includes NETLINK_XFRM. This might not be available on the host kernel.

See #36600 (comment).

Allow cilium agent to start on linux kernels that don't have CONFIG_XFRM.

@julianwiedmann
devices controller: spell out list of required netlink families
a15a993 
Spell out the list of netlink families that we use. Otherwise the netlink
library will pull in a default list (`SupportedNlFamilies`) which
includes NETLINK_XFRM. This might not be available on the host kernel.

See cilium#36600 (comment).

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 21, 2025
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann mentioned this pull request Jan 21, 2025
Closed
3 tasks
@julianwiedmann julianwiedmann marked this pull request as ready for review January 22, 2025 05:56
@julianwiedmann julianwiedmann requested a review from a team as a code owner January 22, 2025 05:56
joamaki
joamaki approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor
@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 23, 2025
@joamaki joamaki added this pull request to the merge queue Jan 23, 2025
Merged via the queue into cilium:main with commit 4e50ea8 Jan 23, 2025
70 checks passed
@rastislavs rastislavs mentioned this pull request Jan 24, 2025
Merged
14 tasks
@rastislavs rastislavs added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 24, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jan 24, 2025
@cilium-release-bot cilium-release-bot bot mentioned this pull request Jan 24, 2025
Merged
@giorio94 giorio94 mentioned this pull request Jan 27, 2025
Merged
8 tasks
@giorio94 giorio94 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Jan 27, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Jan 30, 2025
@julianwiedmann julianwiedmann mentioned this pull request Apr 7, 2025
Merged
@julianwiedmann julianwiedmann deleted the 1.18-netlink-xfrm branch May 9, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julianwiedmann @joamaki @rastislavs @giorio94
0