cilium: Fix device controller's dependency on netfilter #38777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to disable netfilter in the kernel and starting up Cilium with
the below options, it fails as follows:
kernel# cat .config | grep NETFILTER
# CONFIG_NETFILTER is not set
# ./daemon/cilium-agent --enable-ipv4=true --enable-ipv6=false \
--bpf-lb-algorithm=maglev --bpf-lb-maglev-table-size=2039 \
--bpf-lb-mode=dsr --bpf-lb-acceleration=native --devices=enp5s0 \
--bpf-lb-dsr-dispatch=ipip --disable-envoy-version-check=true \
--k8s-kubeconfig-path=$HOME/.kube/config \
--kube-proxy-replacement=true --routing-mode=native \
--enable-ipv4-masquerade=false --ipam=cluster-pool \
--enable-ipip-termination --install-iptables-rules=false \
--enable-l7-proxy=false
[...]
time=2025-04-07T10:40:05Z level=info msg="All Cilium CRDs have been found and are available" module=agent.infra.k8s-synced-crdsync
time="2025-04-07T10:40:05.954428144Z" level=info msg="Local boot ID is \"5efaef07-4a21-4db1-82e7-05c73687cff8\"" subsys=node
time=2025-04-07T10:40:05Z level=error msg="Start hook failed" function="*linux.devicesController.Start (agent.datapath.devices-controller)" error="creating netlink handle: protocol not supported"
time=2025-04-07T10:40:05Z level=error msg="Failed to start hive" error="creating netlink handle: protocol not supported" duration=57.406398ms
time=2025-04-07T10:40:05Z level=info msg="Stopping hive"
time=2025-04-07T10:40:05Z level=info msg="agent.datapath.sysctl.job-reconcile (rev=8)" module=health
time=2025-04-07T10:40:05Z level=info msg="agent.datapath.sysctl.job-refresh (rev=9)" module=health
time=2025-04-07T10:40:05Z level=info msg="agent.infra.k8s-synced-crdsync.job-sync-crds (rev=7)" module=health
time="2025-04-07T10:40:05.955728969Z" level=info msg="Stopped gops server" address="127.0.0.1:9890" subsys=gops
time="2025-04-07T10:40:05.955744039Z" level=fatal msg="failed to start: creating netlink handle: protocol not supported" subsys=daemon
The device controller itself doesn't need anything netfilter related, thus
fix up the handle.
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
|
/test |
aspsk
approved these changes
Apr 7, 2025
dylandreimerink
approved these changes
Apr 7, 2025
|
ah nice, we're slowly stripping this down to the minimum: Should we backport as well? |
Yes, that would be good indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is n
2E8C
ot supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit msg)