8000 Cleanup PointerInterpolatorSuite by isomarcte · Pull Request #1996 · circe/circe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cleanup PointerInterpolatorSuite #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 27, 2022
Merged

Cleanup PointerInterpolatorSuite #1996

merged 5 commits into from
Jul 27, 2022

Conversation

isomarcte
Copy link
Contributor

No description provided.

@isomarcte isomarcte requested a review from zarthross as a code owner July 11, 2022 18:25
@isomarcte
Copy link
Contributor Author

The big fix here is not deconstructing the result of the parse as val Right(expected) because when that is wrong for whatever reason we mask the real failure with a match error.

isomarcte added 3 commits July 11, 2022 12:30
@isomarcte
Flip Parameters To Help Out Inference
93a34f2 
Neither is more expected than the other, so the order here doesn't matter.
@isomarcte
Add Missing Import
ecff754
@isomarcte
Fix Inference
bc13be1
@codecov-commenter
Copy link
codecov-commenter commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #1996 (89c7dfa) into main (3c74a83) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1996      +/-   ##
==========================================
+ Coverage   85.94%   86.06%   +0.11%     
==========================================
  Files          74       74              
  Lines        2554     2554              
  Branches      120      117       -3     
==========================================
+ Hits         2195     2198       +3     
+ Misses        359      356       -3
Flag Coverage Δ
2.12.15 85.85% <ø> (+0.03%) ⬆️
2.13.8 86.05% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/main/scala/io/circe/numbers/BiggerDecimal.scala 88.30% <0.00%> (+1.16%) ⬆️
...re/shared/src/main/scala/io/circe/KeyDecoder.scala 100.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c74a83...89c7dfa. Read the comment docs.

@isomarcte
Copy link
Contributor Author

Test failure is unrelated and fixed in #1997

@isomarcte
Copy link
Contributor Author

@zarthross anything I need to do here?

@zarthross zarthross merged commit d013f8d into circe:main Jul 27, 2022
@isomarcte isomarcte deleted the cleanup-pointer-interpolator-suite branch July 28, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmccoy zmccoy zmccoy approved these changes

@zarthross zarthross zarthross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isomarcte @codecov-commenter @zmccoy @zarthross
0