Use The Jawn Parser For Parsing Sorted Output In Tests #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes circe#1911 The `JSON.parse` call on native JS automatically and always sorts the keys when parsing, but slightly differently than the ordering prescribed by `Order[String]`. This causes tests on the sorted printers to fail under certain circumstances. The fix for this is to use Jawn on JS to get consistent parsing. If we switch to Jawn in general for both JS and the JVM then we can undo this. Note, the issue has never been with the printing, but always with the parsing.
This was referenced Jul 11, 2022
|
Linking to #1941, where I proposed we switch to the Jawn parser on all platforms. |
Codecov Report
@@ Coverage Diff @@
## main #1997 +/- ##
==========================================
+ Coverage 85.94% 86.02% +0.07%
==========================================
Files 74 74
Lines 2554 2554
Branches 117 120 +3
==========================================
+ Hits 2195 2197 +2
+ Misses 359 357 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
armanbilge
approved these changes
Jul 11, 2022
zarthross
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1911
The
JSON.parsecall on native JS automatically and always sorts the keys when parsing, but slightly differently than the ordering prescribed byOrder[String]. This causes tests on the sorted printers to fail under certain circumstances.The fix for this is to use Jawn on JS to get consistent parsing. If we switch to Jawn in general for both JS and the JVM then we can undo this.
Note, the issue has never been with the printing, but always with the parsing.