8000 Fix crash when diffing a stack that has unquoted date strings by aarongorka · Pull Request #768 · cloudtools/stacker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix crash when diffing a stack that has unquoted date strings #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix crash when diffing a stack that has unquoted date strings #768

wants to merge 2 commits into from

Conversation

aarongorka
Copy link
Contributor

Same as #591

@aarongorka
Copy link
Contributor Author

Tested by creating a stack with the current version from pip, crashing stacker with a diff, applying the change and then running diff again to confirm it no longer crashes.

@aarongorka
Copy link
Contributor Author

The failed test step is running python 2.7, I have to ask: what's up with that?

russellballestrini
russellballestrini approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member
@russellballestrini russellballestrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

looks good to me. As for the test failures, they seem unrelated to this PR.

@aarongorka aarongorka closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellballestrini russellballestrini russellballestrini approved these changes

@phobologic phobologic Awaiting requested review from phobologic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongorka @russellballestrini @phobologic
0